chrome/browser/ui/cocoa/toolbar/back_forward_menu_controller.h - Issue 1221173003: [Mac] Inform reference counted objects that hold a weak Browser* when the Browser is being destroye…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/toolbar/back_forward_menu_controller.h

Issue 1221173003: [Mac] Inform reference counted objects that hold a weak Browser* when the Browser is being destroye… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm ('k') | chrome/browser/ui/cocoa/toolbar/back_forward_menu_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/toolbar/back_forward_menu_controller.h

diff --git a/chrome/browser/ui/cocoa/toolbar/back_forward_menu_controller.h b/chrome/browser/ui/cocoa/toolbar/back_forward_menu_controller.h

index e1863415f920142fb990520a65f88c18bcff9449..277f3dbca89afdb6b02483bd5aa5c868fed1b6f7 100644

--- a/chrome/browser/ui/cocoa/toolbar/back_forward_menu_controller.h

+++ b/chrome/browser/ui/cocoa/toolbar/back_forward_menu_controller.h

@@ -9,6 +9,7 @@

#include "base/mac/scoped_nsobject.h"

#include "base/memory/scoped_ptr.h"

+#import "chrome/browser/ui/cocoa/has_weak_browser_pointer.h"

#include "chrome/browser/ui/toolbar/back_forward_menu_model.h"

@class MenuButton;

@@ -21,8 +22,10 @@ const BackForwardMenuType BACK_FORWARD_MENU_TYPE_FORWARD =

// A class that manages the back/forward menu (and delayed-menu button, and

// model).

-@interface BackForwardMenuController : NSObject<NSMenuDelegate> {

+// Implement HasWeakBrowserPointer so we can clean up if the Browser is

+// destroyed.

+@interface BackForwardMenuController

+ : NSObject<NSMenuDelegate, HasWeakBrowserPointer> {

@private

BackForwardMenuType type_;

MenuButton* button_; // Weak; comes from nib.