Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(898)

Side by Side Diff: chrome/browser/ui/cocoa/toolbar/back_forward_menu_controller.h

Issue 1221173003: [Mac] Inform reference counted objects that hold a weak Browser* when the Browser is being destroye… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_COCOA_TOOLBAR_BACK_FORWARD_MENU_CONTROLLER_H_ 5 #ifndef CHROME_BROWSER_UI_COCOA_TOOLBAR_BACK_FORWARD_MENU_CONTROLLER_H_
6 #define CHROME_BROWSER_UI_COCOA_TOOLBAR_BACK_FORWARD_MENU_CONTROLLER_H_ 6 #define CHROME_BROWSER_UI_COCOA_TOOLBAR_BACK_FORWARD_MENU_CONTROLLER_H_
7 7
8 #import <Cocoa/Cocoa.h> 8 #import <Cocoa/Cocoa.h>
9 9
10 #include "base/mac/scoped_nsobject.h" 10 #include "base/mac/scoped_nsobject.h"
11 #include "base/memory/scoped_ptr.h" 11 #include "base/memory/scoped_ptr.h"
12 #import "chrome/browser/ui/cocoa/has_weak_browser_pointer.h"
12 #include "chrome/browser/ui/toolbar/back_forward_menu_model.h" 13 #include "chrome/browser/ui/toolbar/back_forward_menu_model.h"
13 14
14 @class MenuButton; 15 @class MenuButton;
15 16
16 typedef BackForwardMenuModel::ModelType BackForwardMenuType; 17 typedef BackForwardMenuModel::ModelType BackForwardMenuType;
17 const BackForwardMenuType BACK_FORWARD_MENU_TYPE_BACK = 18 const BackForwardMenuType BACK_FORWARD_MENU_TYPE_BACK =
18 BackForwardMenuModel::BACKWARD_MENU; 19 BackForwardMenuModel::BACKWARD_MENU;
19 const BackForwardMenuType BACK_FORWARD_MENU_TYPE_FORWARD = 20 const BackForwardMenuType BACK_FORWARD_MENU_TYPE_FORWARD =
20 BackForwardMenuModel::FORWARD_MENU; 21 BackForwardMenuModel::FORWARD_MENU;
21 22
22 // A class that manages the back/forward menu (and delayed-menu button, and 23 // A class that manages the back/forward menu (and delayed-menu button, and
23 // model). 24 // model).
24 25 // Implement HasWeakBrowserPointer so we can clean up if the Browser is
25 @interface BackForwardMenuController : NSObject<NSMenuDelegate> { 26 // destroyed.
27 @interface BackForwardMenuController
28 : NSObject<NSMenuDelegate, HasWeakBrowserPointer> {
26 @private 29 @private
27 BackForwardMenuType type_; 30 BackForwardMenuType type_;
28 MenuButton* button_; // Weak; comes from nib. 31 MenuButton* button_; // Weak; comes from nib.
29 scoped_ptr<BackForwardMenuModel> model_; 32 scoped_ptr<BackForwardMenuModel> model_;
30 base::scoped_nsobject<NSMenu> backForwardMenu_; 33 base::scoped_nsobject<NSMenu> backForwardMenu_;
31 } 34 }
32 35
33 // Type (back or forwards); can only be set on initialization. 36 // Type (back or forwards); can only be set on initialization.
34 @property(readonly, nonatomic) BackForwardMenuType type; 37 @property(readonly, nonatomic) BackForwardMenuType type;
35 38
36 - (id)initWithBrowser:(Browser*)browser 39 - (id)initWithBrowser:(Browser*)browser
37 modelType:(BackForwardMenuType)type 40 modelType:(BackForwardMenuType)type
38 button:(MenuButton*)button; 41 button:(MenuButton*)button;
39 42
40 @end // @interface BackForwardMenuController 43 @end // @interface BackForwardMenuController
41 44
42 #endif // CHROME_BROWSER_UI_COCOA_TOOLBAR_BACK_FORWARD_MENU_CONTROLLER_H_ 45 #endif // CHROME_BROWSER_UI_COCOA_TOOLBAR_BACK_FORWARD_MENU_CONTROLLER_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm ('k') | chrome/browser/ui/cocoa/toolbar/back_forward_menu_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698