chrome/browser/ui/cocoa/download/download_shelf_controller.mm - Issue 1221173003: [Mac] Inform reference counted objects that hold a weak Browser* when the Browser is being destroye…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/download/download_shelf_controller.mm

Issue 1221173003: [Mac] Inform reference counted objects that hold a weak Browser* when the Browser is being destroye… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix ToolbarActionsBar tests. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/browser_window_controller.mm ('K') | « chrome/browser/ui/cocoa/download/download_shelf_controller.h ('k') | chrome/browser/ui/cocoa/extensions/browser_action_test_util_mac.mm » ('j') | chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/download/download_shelf_controller.mm

diff --git a/chrome/browser/ui/cocoa/download/download_shelf_controller.mm b/chrome/browser/ui/cocoa/download/download_shelf_controller.mm

index ebebb03f18c96560117ed7c28b07ca535c560912..5026bcb6452e38cf19a6035512dad6ef18b2dd5e 100644

--- a/chrome/browser/ui/cocoa/download/download_shelf_controller.mm

+++ b/chrome/browser/ui/cocoa/download/download_shelf_controller.mm

@@ -141,14 +141,11 @@ const NSSize kHoverCloseButtonDefaultSize = { 18, 18 };

[self installTrackingArea];

}

-- (void)dealloc {

+- (void)browserWillBeDestroyed {

[[NSNotificationCenter defaultCenter] removeObserver:self];

- [self cancelAutoClose];

- [self removeTrackingArea];

- // The controllers will unregister themselves as observers when they are

- // deallocated. No need to do that here.

- [super dealloc];

+ [self exiting];

tapted 2015/07/07 04:25:59 I think you can just move the contents of `exiting

jackhou1 2015/07/07 08:33:05 Done.

+ bridge_.reset();

+ navigator_ = nullptr;

}

// Called after the frame's rect has changed; usually when the height is