[Mac] Inform reference counted objects that hold a weak Browser* when the Browser is being destroye…

chrome/browser/ui/cocoa/download/download_shelf_controller.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/download/download_shelf_controller.h"
 
 #include "base/mac/bundle_locations.h"
 #include "base/strings/sys_string_conversions.h"
 #include "chrome/browser/download/download_stats.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 123 matching lines @@
                     selector:@selector(willEnterFullscreen)
                         name:kWillEnterFullscreenNotification
                       object:nil];
   [defaultCenter addObserver:self
                     selector:@selector(willLeaveFullscreen)
                         name:kWillLeaveFullscreenNotification
                       object:nil];
   [self installTrackingArea];
 }
 
-- (void)dealloc {
+- (void)browserWillBeDestroyed {
   [[NSNotificationCenter defaultCenter] removeObserver:self];
-  [self cancelAutoClose];
-  [self removeTrackingArea];
-
-  // The controllers will unregister themselves as observers when they are
-  // deallocated. No need to do that here.
-  [super dealloc];
+  [self exiting];

[tapted, 2015/07/07 04:25:59]

I think you can just move the contents of `exiting` into this function.

[jackhou1, 2015/07/07 08:33:05]

Done.

+  bridge_.reset();
+  navigator_ = nullptr;
 }
 
 // Called after the frame's rect has changed; usually when the height is
 // animated.
 - (void)viewFrameDidChange:(NSNotification*)notification {
   // Anchor subviews at the top of |view|, so that it looks like the shelf
   // is sliding out.
   CGFloat newShelfHeight = NSHeight([[self view] frame]);
   if (newShelfHeight == currentShelfHeight_)
     return;
@@ skipping 342 matching lines @@
   }
 
   // Set the tracking off to create a new tracking area for the control.
   // When changing the bounds/frame on a HoverButton, the tracking isn't updated
   // correctly, it needs to be turned off and back on.
   [hoverCloseButton_ setTrackingEnabled:NO];
   [hoverCloseButton_ setFrame:bounds];
   [hoverCloseButton_ setTrackingEnabled:YES];
 }
 @end