Issue 1221163002: Remove two unused functions from dart:sky.internals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1221163002: Remove two unused functions from dart:sky.internals (Closed)

Created:
5 years, 5 months ago by abarth-chromium

Modified:
5 years, 5 months ago

Reviewers:
eseidel1

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, gregsimon, jackson_old, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Remove two unused functions from dart:sky.internals These functions used to support testing, but they're no longer used by any tests now that we've deleted the DOM-based world. Really we should merge dart:sky.internals into dart:sky, but that's a CL for another day. TBR=eseidel@google.com Committed: https://chromium.googlesource.com/external/mojo/+/b8a5576e3c0ee13bd6834233a4d6347a6c669457

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -34 lines)			Patch
M	sky/engine/bindings/sky_internals.dart	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sky/shell/ui/internals.cc	View	2 chunks	+0 lines, -10 lines	0 comments	Download
M	sky/viewer/internals.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sky/viewer/internals.cc	View	3 chunks	+0 lines, -20 lines	0 comments	Download

Total messages: 2 (0 generated)

abarth-chromium

5 years, 5 months ago (2015-07-02 20:09:45 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b8a5576e3c0ee13bd6834233a4d6347a6c669457 (presubmit successful).