Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Unified Diff: sky/viewer/internals.cc

Issue 1221163002: Remove two unused functions from dart:sky.internals (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/viewer/internals.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/viewer/internals.cc
diff --git a/sky/viewer/internals.cc b/sky/viewer/internals.cc
index 208f698a80b0cb3098b452daa94c442e27cf3744..c2d7df3788d6d493cfa2c823ae905935089b748e 100644
--- a/sky/viewer/internals.cc
+++ b/sky/viewer/internals.cc
@@ -25,21 +25,11 @@ Internals* GetInternals() {
return static_cast<Internals*>(state->GetUserData(&kInternalsKey));
}
-void ContentAsText(Dart_NativeArguments args) {
- Dart_Handle result = StdStringToDart(GetInternals()->ContentAsText());
- Dart_SetReturnValue(args, result);
-}
-
void NotifyTestComplete(Dart_NativeArguments args) {
Dart_Handle test_result = Dart_GetNativeArgument(args, 0);
GetInternals()->NotifyTestComplete(StdStringFromDart(test_result));
}
-void RenderTreeAsText(Dart_NativeArguments args) {
- Dart_Handle result = StdStringToDart(GetInternals()->RenderTreeAsText());
- Dart_SetReturnValue(args, result);
-}
-
void TakeShellProxyHandle(Dart_NativeArguments args) {
Dart_SetIntegerReturnValue(args,
GetInternals()->TakeShellProxyHandle().value());
@@ -61,9 +51,7 @@ void TakeServiceRegistry(Dart_NativeArguments args) {
}
const DartBuiltin::Natives kNativeFunctions[] = {
- {"contentAsText", ContentAsText, 0},
{"notifyTestComplete", NotifyTestComplete, 1},
- {"renderTreeAsText", RenderTreeAsText, 0},
{"takeShellProxyHandle", TakeShellProxyHandle, 0},
{"takeServicesProvidedByEmbedder", TakeServicesProvidedByEmbedder, 0},
{"takeServicesProvidedToEmbedder", TakeServicesProvidedToEmbedder, 0},
@@ -108,14 +96,6 @@ Internals::Internals(DocumentView* document_view)
Internals::~Internals() {
}
-std::string Internals::RenderTreeAsText() {
- return std::string();
-}
-
-std::string Internals::ContentAsText() {
- return std::string();
-}
-
void Internals::NotifyTestComplete(const std::string& test_result) {
if (!RuntimeFlags::Get().testing())
return;
« no previous file with comments | « sky/viewer/internals.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698