Set the original external texture to new layer when it's copied to the old layer.

Set the original external texture to new layer when it's copied to the old layer.

Looks like this is a bug in https://codereview.chromium.org/10910242.

BUG=175211
TEST=manual. see bug

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181980

[piman, 2013-02-12 03:05:51]

lgtm

[oshima, 2013-02-12 03:13:30]

sky -> OWNERS review

[sky, 2013-02-12 03:31:54]

https://codereview.chromium.org/12211121/diff/4002/ui/aura/window.cc
File ui/aura/window.cc (right):

https://codereview.chromium.org/12211121/diff/4002/ui/aura/window.cc#newcode160
ui/aura/window.cc:160: if (delegate_ && old_texture)
This code is also hit when maximizing. Does setting an external texture like
this lead to any problems there?

[oshima, 2013-02-12 04:03:23]

https://codereview.chromium.org/12211121/diff/4002/ui/aura/window.cc
File ui/aura/window.cc (right):

https://codereview.chromium.org/12211121/diff/4002/ui/aura/window.cc#newcode160
ui/aura/window.cc:160: if (delegate_ && old_texture)
On 2013/02/12 03:31:54, sky wrote:
> This code is also hit when maximizing. Does setting an external texture like
> this lead to any problems there?

I tested (un)maximizing as well and it looks fine.
I guess this was hard to notice with maxizming as the new layer is fading in?

[sky, 2013-02-12 17:01:24]

LGTM

https://codereview.chromium.org/12211121/diff/4002/ui/aura/window.cc
File ui/aura/window.cc (right):

https://codereview.chromium.org/12211121/diff/4002/ui/aura/window.cc#newcode160
ui/aura/window.cc:160: if (delegate_ && old_texture)
On 2013/02/12 04:03:23, oshima wrote:
> On 2013/02/12 03:31:54, sky wrote:
> > This code is also hit when maximizing. Does setting an external texture like
> > this lead to any problems there?
> 
> I tested (un)maximizing as well and it looks fine.
> I guess this was hard to notice with maxizming as the new layer is fading in?
> 
> 

When you maximize/restore we change the size immediately after this. Which
should mean the old texture isn't used. I just wanted to make sure your code
didn't cause any artifacats there.

[commit-bot: I haz the power, 2013-02-12 17:29:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/12211121/4002

[commit-bot: I haz the power, 2013-02-12 19:40:10]

Change committed as 181980