Makes copying layers clone external textures.

Makes copying layers clone external textures.

BUG=146428
TEST=none
R=piman@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=156571

[piman, 2012-09-13 00:19:10]

Overall this should work. Just minor details about transitional states.

http://codereview.chromium.org/10910242/diff/2001/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_view_aura.cc (right):

http://codereview.chromium.org/10910242/diff/2001/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_view_aura.cc:1282: if (it ==
image_transport_clients_.end())
Maybe also check host_->is_accelerated_compositing_active() otherwise during
some transitional states I believe current_surface_ may be set (and you'll find
a client, but it will be stale).

http://codereview.chromium.org/10910242/diff/2001/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_view_aura.cc:1287: gfx::Size
size_in_pixels(ConvertSizeToPixel(this, window_->bounds().size()));
How about texture->size() ? That way you're guaranteed to copy the exact size of
the texture, regardless of transitional states (e.g. we're waiting for the
renderer to produce a texture of the correct size), or the
layer->scale_content() settings.

http://codereview.chromium.org/10910242/diff/2001/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_view_aura.cc:1288:
WebKit::WebGLId surface_handle =
nit: I'd name this texture_id or something. It's really not linked to a notion
of a surface any more.

[sky, 2012-09-13 00:28:01]

I incorporated all your feedback. New patchset uploaded.

[piman, 2012-09-13 00:28:59]

lgtm

[sky, 2012-09-13 00:29:43]

Ben, did you want to take a look at the aura changes?

[Ben Goodger (Google), 2012-09-13 15:34:35]

lgtm

[piman, 2012-09-14 02:27:17]

http://codereview.chromium.org/10910242/diff/3003/ui/aura/window.cc
File ui/aura/window.cc (right):

http://codereview.chromium.org/10910242/diff/3003/ui/aura/window.cc#newcode171
ui/aura/window.cc:171: old_layer->SetExternalTexture(delegate_->CopyTexture());
I just realized, the ui::Texture doesn't take ownership of the texture ID, so
this will leak the texture.

[sky, 2012-09-14 16:07:58]

Oi, this must be the leak I was just asked about. I'll look at it ASAP