Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2838)

Unified Diff: base/debug/crash_logging.h

Issue 12211080: Change crash keys to be registered with a maximum length instead of number of chunks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Win fix Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/debug/crash_logging.cc » ('j') | base/debug/crash_logging.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/debug/crash_logging.h
diff --git a/base/debug/crash_logging.h b/base/debug/crash_logging.h
index c81bb24aa06a0d8c6d5da07ef8a890b4de92153d..c1cc14fec81dd7909f947b9620f4c8705b2e94e0 100644
--- a/base/debug/crash_logging.h
+++ b/base/debug/crash_logging.h
@@ -32,7 +32,7 @@ BASE_EXPORT void SetCrashKeyToStackTrace(const base::StringPiece& key,
const StackTrace& trace);
// Formats |count| instruction pointers from |addresses| using %p and
-// sets the resulting string as a value for crash key |key. A maximum of 23
+// sets the resulting string as a value for crash key |key|. A maximum of 23
// items will be encoded, since breakpad limits values to 255 bytes.
BASE_EXPORT void SetCrashKeyFromAddresses(const base::StringPiece& key,
const void* const* addresses,
@@ -56,10 +56,11 @@ struct BASE_EXPORT CrashKey {
// The name of the crash key, used in the above functions.
const char* const key_name;
- // For values longer than chunk_max_length, the value can be chunked into
- // values named "key_name-1", "key_name-2", etc. This is the maximum number of
- // numbered chunks to use before the value is truncated.
- size_t num_chunks;
+ // The maximum length for a value. If the value is longer than this, it will
+ // be truncated. If the value is larger than the |chunk_max_length| passed to
+ // InitCrashKeys() but less than this value, it will be split into multiple
+ // numbered chunks.
+ size_t max_length;
};
// Before the crash key logging mechanism can be used, all crash keys must be
« no previous file with comments | « no previous file | base/debug/crash_logging.cc » ('j') | base/debug/crash_logging.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698