Change crash keys to be registered with a maximum length instead of number of chunks.

base/debug/crash_logging.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_DEBUG_CRASH_LOGGING_H_
 #define BASE_DEBUG_CRASH_LOGGING_H_
 
 #include <string>
 
 #include "base/base_export.h"
@@ skipping 14 matching lines @@
 // Set or clear a specific key-value pair from the crash metadata.
 BASE_EXPORT void SetCrashKeyValue(const base::StringPiece& key,
                                   const base::StringPiece& value);
 BASE_EXPORT void ClearCrashKey(const base::StringPiece& key);
 
 // Records the given StackTrace into a crash key.
 BASE_EXPORT void SetCrashKeyToStackTrace(const base::StringPiece& key,
                                          const StackTrace& trace);
 
 // Formats |count| instruction pointers from |addresses| using %p and
-// sets the resulting string as a value for crash key |key. A maximum of 23
+// sets the resulting string as a value for crash key |key|. A maximum of 23
 // items will be encoded, since breakpad limits values to 255 bytes.
 BASE_EXPORT void SetCrashKeyFromAddresses(const base::StringPiece& key,
                                           const void* const* addresses,
                                           size_t count);
 
 // A scoper that sets the specified key to value for the lifetime of the
 // object, and clears it on destruction.
 class BASE_EXPORT ScopedCrashKey {
  public:
   ScopedCrashKey(const base::StringPiece& key, const base::StringPiece& value);
   ~ScopedCrashKey();
 
  private:
   std::string key_;
 
   DISALLOW_COPY_AND_ASSIGN(ScopedCrashKey);
 };
 
 // Before setting values for a key, all the keys must be registered.
 struct BASE_EXPORT CrashKey {
   // The name of the crash key, used in the above functions.
   const char* const key_name;
 
-  // For values longer than chunk_max_length, the value can be chunked into
-  // values named "key_name-1", "key_name-2", etc. This is the maximum number of
-  // numbered chunks to use before the value is truncated.
-  size_t num_chunks;
+  // The maximum length for a value. If the value is longer than this, it will
+  // be truncated. If the value is larger than the |chunk_max_length| passed to
+  // InitCrashKeys() but less than this value, it will be split into multiple
+  // numbered chunks.
+  size_t max_length;
 };
 
 // Before the crash key logging mechanism can be used, all crash keys must be
 // registered with this function. The function returns the amount of space
 // the crash reporting implementation should allocate space for the registered
 // crash keys. |chunk_max_length| is the maximum size that a value in a single
 // chunk can be.
 BASE_EXPORT size_t InitCrashKeys(const CrashKey* const keys, size_t count,
                                  size_t chunk_max_length);
 
@@ skipping 17 matching lines @@
     const base::StringPiece& value,
     size_t chunk_max_length);
 
 // Resets the crash key system so it can be reinitialized. For testing only.
 BASE_EXPORT void ResetCrashLoggingForTesting();
 
 }  // namespace debug
 }  // namespace base
 
 #endif  // BASE_DEBUG_CRASH_LOGGING_H_