Implementing geolocation for the Android Webview

android_webview/browser/aw_content_browser_client.cc

Index: android_webview/browser/aw_content_browser_client.cc
diff --git a/android_webview/browser/aw_content_browser_client.cc b/android_webview/browser/aw_content_browser_client.cc
index 5a53dd1cb0f381f96c5b860ad44640bf7912af37..ca0574ff78786b38ced8697dc0e61f754ae7c5ee 100644
--- a/android_webview/browser/aw_content_browser_client.cc
+++ b/android_webview/browser/aw_content_browser_client.cc
@@ -28,7 +28,9 @@ class DummyAccessTokenStore : public content::AccessTokenStore {
   DummyAccessTokenStore() { }
 
   virtual void LoadAccessTokens(
-      const LoadAccessTokensCallbackType& request) OVERRIDE { }
+      const LoadAccessTokensCallbackType& request) OVERRIDE {
+    request.Run(access_token_set_, NULL);

[joth, 2013/02/06 22:09:51]

comment that access tokens not used on android, but we need to complete the
request to startup the geolocation subsystem?

[Kristian Monsen, 2013/02/08 00:07:44]

Done.

+  }
 
  private:
   virtual ~DummyAccessTokenStore() { }
@@ -36,6 +38,8 @@ class DummyAccessTokenStore : public content::AccessTokenStore {
   virtual void SaveAccessToken(

[boliu, 2013/02/06 20:29:54]

Really weird two overriden methods from same class belong in different
visibility blocks. Can you move this to public and Add a comment saying these
implementing content::AccessTokenStore

[Kristian Monsen, 2013/02/08 00:07:44]

Done.

       const GURL& server_url, const string16& access_token) OVERRIDE { }
 
+  AccessTokenStore::AccessTokenSet access_token_set_;

[joth, 2013/02/06 22:09:51]

I think you can make this a local in the method above rather than a member, as
request.Run() will take a deep copy anyway.

[Kristian Monsen, 2013/02/08 00:07:44]

Done.

+
   DISALLOW_COPY_AND_ASSIGN(DummyAccessTokenStore);
 };