Implementing geolocation for the Android Webview

android_webview/browser/aw_content_browser_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "android_webview/browser/aw_content_browser_client.h"
 
 #include "android_webview/browser/aw_browser_main_parts.h"
 #include "android_webview/browser/aw_cookie_access_policy.h"
 #include "android_webview/browser/aw_quota_permission_context.h"
 #include "android_webview/browser/net_disk_cache_remover.h"
 #include "android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.h"
 #include "android_webview/common/url_constants.h"
 #include "base/android/locale_utils.h"
 #include "base/base_paths_android.h"
 #include "base/path_service.h"
 #include "content/public/browser/access_token_store.h"
 #include "content/public/browser/child_process_security_policy.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/common/url_constants.h"
 #include "grit/ui_resources.h"
 #include "ui/base/resource/resource_bundle.h"
 
 namespace {
 
 class DummyAccessTokenStore : public content::AccessTokenStore {

[boliu, 2013/02/06 20:29:54]

Rename this class now?

[Kristian Monsen, 2013/02/08 00:07:44]

Renamed it to AwAccessTokenStore, but really not much more functionality now
than before.

  public:
   DummyAccessTokenStore() { }
 
   virtual void LoadAccessTokens(
-      const LoadAccessTokensCallbackType& request) OVERRIDE { }
+      const LoadAccessTokensCallbackType& request) OVERRIDE {
+    request.Run(access_token_set_, NULL);

[joth, 2013/02/06 22:09:51]

comment that access tokens not used on android, but we need to complete the
request to startup the geolocation subsystem?

[Kristian Monsen, 2013/02/08 00:07:44]

Done.

+  }
 
  private:
   virtual ~DummyAccessTokenStore() { }
 
   virtual void SaveAccessToken(

[boliu, 2013/02/06 20:29:54]

Really weird two overriden methods from same class belong in different
visibility blocks. Can you move this to public and Add a comment saying these
implementing content::AccessTokenStore

[Kristian Monsen, 2013/02/08 00:07:44]

Done.

       const GURL& server_url, const string16& access_token) OVERRIDE { }
 
+  AccessTokenStore::AccessTokenSet access_token_set_;

[joth, 2013/02/06 22:09:51]

I think you can make this a local in the method above rather than a member, as
request.Run() will take a deep copy anyway.

[Kristian Monsen, 2013/02/08 00:07:44]

Done.

+
   DISALLOW_COPY_AND_ASSIGN(DummyAccessTokenStore);
 };
 
 }
 
 namespace android_webview {
 
 AwContentBrowserClient::AwContentBrowserClient(
     ViewDelegateFactoryFn* view_delegate_factory,
     GeolocationPermissionFactoryFn* geolocation_permission_factory)
@@ skipping 278 matching lines @@
 
 bool AwContentBrowserClient::AllowPepperSocketAPI(
     content::BrowserContext* browser_context,
     const GURL& url,
     const content::SocketPermissionRequest& params) {
   NOTREACHED() << "Android WebView does not support plugins";
   return false;
 }
 
 }  // namespace android_webview