Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 1221103003: [turbofan] Move context specialization into JSContextSpecializer. (Closed)

Created:
5 years, 5 months ago by Michael Starzinger
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Move context specialization into JSContextSpecializer. Remove the context specialization hack from the AstGraphBuilder, and properly specialize to the function context in the JSContextSpecializer. And replace the correct context in the JSInliner. R=bmeurer@chromium.org,danno@chromium.org,titzer@chromium.org

Patch Set 1 #

Patch Set 2 : Fix predicate. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -73 lines) Patch
M src/compiler/ast-graph-builder.h View 3 chunks +4 lines, -7 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 6 chunks +24 lines, -29 lines 2 comments Download
M src/compiler/js-context-specialization.h View 1 chunk +14 lines, -6 lines 0 comments Download
M src/compiler/js-context-specialization.cc View 1 chunk +19 lines, -4 lines 0 comments Download
M src/compiler/js-inlining.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/js-inlining.cc View 4 chunks +9 lines, -10 lines 0 comments Download
M src/compiler/pipeline.cc View 4 chunks +8 lines, -6 lines 0 comments Download
M test/cctest/compiler/test-js-context-specialization.cc View 10 chunks +11 lines, -10 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 4 (1 generated)
Michael Starzinger
5 years, 5 months ago (2015-07-02 13:49:38 UTC) #2
titzer
https://codereview.chromium.org/1221103003/diff/20001/src/compiler/ast-graph-builder.cc File src/compiler/ast-graph-builder.cc (right): https://codereview.chromium.org/1221103003/diff/20001/src/compiler/ast-graph-builder.cc#newcode4081 src/compiler/ast-graph-builder.cc:4081: // TODO(titzer): use a real OSR value here; a ...
5 years, 5 months ago (2015-07-03 09:28:17 UTC) #3
Michael Starzinger
5 years, 5 months ago (2015-07-06 13:08:40 UTC) #4
Closing, superseded by: https://codereview.chromium.org/1218873005/

https://codereview.chromium.org/1221103003/diff/20001/src/compiler/ast-graph-...
File src/compiler/ast-graph-builder.cc (right):

https://codereview.chromium.org/1221103003/diff/20001/src/compiler/ast-graph-...
src/compiler/ast-graph-builder.cc:4081: // TODO(titzer): use a real OSR value
here; a parameter works by accident.
On 2015/07/03 09:28:17, titzer wrote:
> To get rid of this TODO, we need a special OSR value that will represent the
> context on the stack that the linkage knows about. Then context specialization
> won't be confused by seeing a weird parameter that really represents an OSR
> value.
> 
> We should do this in a separate CL first.

Done, see: https://codereview.chromium.org/1213043005/

Powered by Google App Engine
This is Rietveld 408576698