Issue 1220013003: [turbofan] Fix bogus materialization from frame with OSR.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1220013003: [turbofan] Fix bogus materialization from frame with OSR. (Closed)

Created:
5 years, 5 months ago by Michael Starzinger

Modified:
5 years, 5 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@local_contrib-1218873005

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

[turbofan] Fix bogus materialization from frame with OSR. The context constant cannot be materialized from the frame when we are compiling for OSR, because the context spill slot contains the current instead of the outermost context in full-codegen. R=bmeurer@chromium.org Committed: https://crrev.com/b8ecd94c7212e1d2ff7b85e2d02d5c8c0aed4161 Cr-Commit-Position: refs/heads/master@{#29472}

Patch Set 1 #

Patch Set 2 : Add regression test. #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -1 line)			Patch
	M	src/compiler/code-generator.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	A	test/mjsunit/regress/regress-osr-context.js	View	1	1 chunk	+19 lines, -0 lines	0 comments	Download

Depends on Patchset:

Issue 1221103003 Patch 20001

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1220013003/20001

5 years, 5 months ago (2015-07-06 03:12:59 UTC) #4

commit-bot: I haz the power

5 years, 5 months ago (2015-07-06 03:40:35 UTC) #6

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/b8ecd94c7212e1d2ff7b85e2d02d5c8c0aed4161
Cr-Commit-Position: refs/heads/master@{#29472}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages