Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 12211026: Avoid creating new TestingPrefServiceSyncable (Closed)

Created:
7 years, 10 months ago by Joe Thomas
Modified:
7 years, 10 months ago
CC:
chromium-reviews, Yoyo Zhou
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Avoid creating new TestingPrefServiceSyncable Allow the unittest to use Profile::GetPref() instead of creating its own Pref. This also helps to solve the unit test crash in https://codereview.chromium.org/11968032/. Context: With https://codereview.chromium.org/11968032/, GTKThemeService will be started at Profile creation which creates Profile's Pref. Later the new TestingPrefServiceSyncable that is created in ProtocolHandlerRegistryTest::SetUp overwrites Profile's Pref and leads to a crash in GTKThemeService's d'tor due to invalid pointer. TBR=ben@chromium.org BUG=none TEST=ProtocolHandlerRegistryTest.* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181642

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc View 3 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Joe Thomas
joi@ Could you please review this patch? It is mentioned as TODO in your name. ...
7 years, 10 months ago (2013-02-06 01:21:52 UTC) #1
Jói
LGTM
7 years, 10 months ago (2013-02-06 12:29:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/MHX348@motorola.com/12211026/1
7 years, 10 months ago (2013-02-06 20:25:09 UTC) #3
commit-bot: I haz the power
Presubmit check for 12211026-1 failed and returned exit status 1. Running presubmit commit checks ...
7 years, 10 months ago (2013-02-06 20:25:11 UTC) #4
Joe Thomas
+ Ben for OWNERS
7 years, 10 months ago (2013-02-06 20:26:40 UTC) #5
Joe Thomas
TBR=ben
7 years, 10 months ago (2013-02-10 03:20:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/MHX348@motorola.com/12211026/1
7 years, 10 months ago (2013-02-10 03:20:28 UTC) #7
commit-bot: I haz the power
7 years, 10 months ago (2013-02-10 05:25:23 UTC) #8
Message was sent while issue was closed.
Change committed as 181642

Powered by Google App Engine
This is Rietveld 408576698