content/renderer/render_frame_impl.cc - Issue 1221083007: PlzNavigate: remove extraneous DidStartLoading IPC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.cc

Issue 1221083007: PlzNavigate: remove extraneous DidStartLoading IPC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_frame_impl.cc

diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc

index 094ebe88c06436458f2a162326fd408e02c635ef..cb98f31851ceb080b6407ed8fe35f136514abbca 100644

--- a/content/renderer/render_frame_impl.cc

+++ b/content/renderer/render_frame_impl.cc

@@ -4757,7 +4757,6 @@ void RenderFrameImpl::BeginNavigation(blink::WebURLRequest* request) {

// TODO(clamy): Same-document navigations should not be sent back to the

// browser.

// TODO(clamy): Data urls should not be sent back to the browser either.

nasko 2015/07/07 14:56:32 Sidenote: Isn't this TODO taken care of by Fabrice

clamy 2015/07/07 15:13:50 Indeed. Removed the TODO.

- Send(new FrameHostMsg_DidStartLoading(routing_id_, true));

Send(new FrameHostMsg_BeginNavigation(

routing_id_, MakeCommonNavigationParams(request),

BeginNavigationParams(request->httpMethod().latin1(),

« no previous file with comments | « no previous file | no next file » | no next file with comments »