Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Side by Side Diff: content/renderer/render_frame_impl.cc

Issue 1221083007: PlzNavigate: remove extraneous DidStartLoading IPC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/render_frame_impl.h" 5 #include "content/renderer/render_frame_impl.h"
6 6
7 #include <map> 7 #include <map>
8 #include <string> 8 #include <string>
9 9
10 #include "base/auto_reset.h" 10 #include "base/auto_reset.h"
(...skipping 4738 matching lines...) Expand 10 before | Expand all | Expand 10 after
4749 // implementation of willSendRequest for the various InspectorAgents 4749 // implementation of willSendRequest for the various InspectorAgents
4750 // (devtools). 4750 // (devtools).
4751 // 4751 //
4752 // TODO(clamy): Apply devtools override. 4752 // TODO(clamy): Apply devtools override.
4753 // TODO(clamy): Make sure that navigation requests are not modified somewhere 4753 // TODO(clamy): Make sure that navigation requests are not modified somewhere
4754 // else in blink. 4754 // else in blink.
4755 willSendRequest(frame_, 0, *request, blink::WebURLResponse()); 4755 willSendRequest(frame_, 0, *request, blink::WebURLResponse());
4756 4756
4757 // TODO(clamy): Same-document navigations should not be sent back to the 4757 // TODO(clamy): Same-document navigations should not be sent back to the
4758 // browser. 4758 // browser.
4759 // TODO(clamy): Data urls should not be sent back to the browser either. 4759 // TODO(clamy): Data urls should not be sent back to the browser either.
nasko 2015/07/07 14:56:32 Sidenote: Isn't this TODO taken care of by Fabrice
clamy 2015/07/07 15:13:50 Indeed. Removed the TODO.
4760 Send(new FrameHostMsg_DidStartLoading(routing_id_, true));
4761 Send(new FrameHostMsg_BeginNavigation( 4760 Send(new FrameHostMsg_BeginNavigation(
4762 routing_id_, MakeCommonNavigationParams(request), 4761 routing_id_, MakeCommonNavigationParams(request),
4763 BeginNavigationParams(request->httpMethod().latin1(), 4762 BeginNavigationParams(request->httpMethod().latin1(),
4764 GetWebURLRequestHeaders(*request), 4763 GetWebURLRequestHeaders(*request),
4765 GetLoadFlagsForWebURLRequest(*request), 4764 GetLoadFlagsForWebURLRequest(*request),
4766 request->hasUserGesture()), 4765 request->hasUserGesture()),
4767 GetRequestBodyForWebURLRequest(*request))); 4766 GetRequestBodyForWebURLRequest(*request)));
4768 } 4767 }
4769 4768
4770 void RenderFrameImpl::LoadDataURL(const CommonNavigationParams& params, 4769 void RenderFrameImpl::LoadDataURL(const CommonNavigationParams& params,
(...skipping 241 matching lines...) Expand 10 before | Expand all | Expand 10 after
5012 void RenderFrameImpl::RegisterMojoServices() { 5011 void RenderFrameImpl::RegisterMojoServices() {
5013 // Only main frame have ImageDownloader service. 5012 // Only main frame have ImageDownloader service.
5014 if (!frame_->parent()) { 5013 if (!frame_->parent()) {
5015 GetServiceRegistry()->AddService<image_downloader::ImageDownloader>( 5014 GetServiceRegistry()->AddService<image_downloader::ImageDownloader>(
5016 base::Bind(&ImageDownloaderImpl::CreateMojoService, 5015 base::Bind(&ImageDownloaderImpl::CreateMojoService,
5017 base::Unretained(this))); 5016 base::Unretained(this)));
5018 } 5017 }
5019 } 5018 }
5020 5019
5021 } // namespace content 5020 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698