Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 12210111: Hookup new ice state callbacks OnIceConnectionChange and OnIceGatheringChange from PeerConnectionOb… (Closed)

Created:
7 years, 10 months ago by perkj_chrome
Modified:
7 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Hookup new ice state callbacks OnIceConnectionChange and OnIceGatheringChange from PeerConnectionObserver. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181777

Patch Set 1 #

Patch Set 2 : merge with latest code base. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -159 lines) Patch
M content/renderer/media/mock_peer_connection_impl.h View 1 3 chunks +20 lines, -9 lines 0 comments Download
M content/renderer/media/mock_peer_connection_impl.cc View 1 3 chunks +1 line, -27 lines 0 comments Download
M content/renderer/media/mock_web_rtc_peer_connection_handler_client.h View 2 chunks +11 lines, -4 lines 0 comments Download
M content/renderer/media/mock_web_rtc_peer_connection_handler_client.cc View 2 chunks +11 lines, -3 lines 0 comments Download
M content/renderer/media/rtc_peer_connection_handler.h View 1 2 chunks +9 lines, -2 lines 0 comments Download
M content/renderer/media/rtc_peer_connection_handler.cc View 1 3 chunks +60 lines, -51 lines 0 comments Download
M content/renderer/media/rtc_peer_connection_handler_unittest.cc View 1 2 chunks +68 lines, -63 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
perkj_chrome
Hi I prepared this patch to accompany Bens libjingle state change patch. But since that ...
7 years, 10 months ago (2013-02-11 15:42:58 UTC) #1
perkj_chrome
7 years, 10 months ago (2013-02-11 16:53:51 UTC) #2
perkj_chrome
Adding Tommi as owner. Can you please review?
7 years, 10 months ago (2013-02-11 16:54:41 UTC) #3
tommi (sloooow) - chröme
lgtm
7 years, 10 months ago (2013-02-11 17:03:20 UTC) #4
commit-bot: I haz the power
7 years, 10 months ago (2013-02-11 21:35:03 UTC) #5

Powered by Google App Engine
This is Rietveld 408576698