src/variables.cc - Issue 12210083: Renamed "symbols" to "internalized strings" throughout the code base,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/variables.cc

Issue 12210083: Renamed "symbols" to "internalized strings" throughout the code base, (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed Yang's comments Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/variables.cc

diff --git a/src/variables.cc b/src/variables.cc

index 916121791798489d434acb8637f088327891d62a..488da42ce665ed7322ca7f53e27fc3ec9c109e58 100644

--- a/src/variables.cc

+++ b/src/variables.cc

@@ -76,7 +76,7 @@ Variable::Variable(Scope* scope,

initialization_flag_(initialization_flag),

interface_(interface) {

// Names must be canonicalized for fast equality checks.

- ASSERT(name->IsSymbol());

+ ASSERT(name->IsInternalizedString());

// Var declared variables never need initialization.

ASSERT(!(mode == VAR && initialization_flag == kNeedsInitialization));

}

« no previous file with comments | « src/variables.h ('k') | src/x64/builtins-x64.cc » ('j') | no next file with comments »