src/variables.h - Issue 12210083: Renamed "symbols" to "internalized strings" throughout the code base,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/variables.h

Issue 12210083: Renamed "symbols" to "internalized strings" throughout the code base, (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed Yang's comments Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/variables.h

diff --git a/src/variables.h b/src/variables.h

index bb35ee88b548e726164a7d8a45a62469a1e23b61..39451d5dfb1df987e0a2528365be3354760e019f 100644

--- a/src/variables.h

+++ b/src/variables.h

@@ -131,7 +131,7 @@ class Variable: public ZoneObject {

// True if the variable is named eval and not known to be shadowed.

bool is_possibly_eval(Isolate* isolate) const {

- return IsVariable(isolate->factory()->eval_symbol());

+ return IsVariable(isolate->factory()->eval_string());

}

Variable* local_if_not_shadowed() const {

« no previous file with comments | « src/v8-counters.h ('k') | src/variables.cc » ('j') | no next file with comments »