Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: src/liveedit.cc

Issue 12210083: Renamed "symbols" to "internalized strings" throughout the code base, (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed Yang's comments Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/json-stringifier.h ('k') | src/log-utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/liveedit.cc
diff --git a/src/liveedit.cc b/src/liveedit.cc
index 2502ae688aa7116284b05c0b225eb5eeb079cec6..91734af5eebe3e864a26b41880bfe1dae4ae7c44 100644
--- a/src/liveedit.cc
+++ b/src/liveedit.cc
@@ -951,12 +951,12 @@ JSArray* LiveEdit::GatherCompileInfo(Handle<Script> script,
rethrow_exception = Handle<JSObject>::cast(exception);
Factory* factory = isolate->factory();
- Handle<String> start_pos_key =
- factory->LookupOneByteSymbol(STATIC_ASCII_VECTOR("startPosition"));
- Handle<String> end_pos_key =
- factory->LookupOneByteSymbol(STATIC_ASCII_VECTOR("endPosition"));
- Handle<String> script_obj_key =
- factory->LookupOneByteSymbol(STATIC_ASCII_VECTOR("scriptObject"));
+ Handle<String> start_pos_key = factory->InternalizeOneByteString(
+ STATIC_ASCII_VECTOR("startPosition"));
+ Handle<String> end_pos_key = factory->InternalizeOneByteString(
+ STATIC_ASCII_VECTOR("endPosition"));
+ Handle<String> script_obj_key = factory->InternalizeOneByteString(
+ STATIC_ASCII_VECTOR("scriptObject"));
Handle<Smi> start_pos(Smi::FromInt(message_location.start_pos()));
Handle<Smi> end_pos(Smi::FromInt(message_location.end_pos()));
Handle<JSValue> script_obj = GetScriptWrapper(message_location.script());
« no previous file with comments | « src/json-stringifier.h ('k') | src/log-utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698