src/log-utils.cc - Issue 12210083: Renamed "symbols" to "internalized strings" throughout the code base,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/log-utils.cc

Issue 12210083: Renamed "symbols" to "internalized strings" throughout the code base, (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed Yang's comments Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/log-utils.cc

diff --git a/src/log-utils.cc b/src/log-utils.cc

index d8d92cbe211607f03e2a6f131f6f2f481b47f023..830c3daa9cce16b2ab856abfe1eba84f011ab934 100644

--- a/src/log-utils.cc

+++ b/src/log-utils.cc

@@ -262,7 +262,7 @@ void LogMessageBuilder::AppendDetailed(String* str, bool show_impl_info) {

Append(str->IsOneByteRepresentation() ? 'a' : '2');

if (StringShape(str).IsExternal())

Append('e');

- if (StringShape(str).IsSymbol())

+ if (StringShape(str).IsInternalized())

Append('#');

Append(":%i:", str->length());

}

« no previous file with comments | « src/liveedit.cc ('k') | src/mark-compact.h » ('j') | no next file with comments »