Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: src/gdb-jit.cc

Issue 12210083: Renamed "symbols" to "internalized strings" throughout the code base, (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/gdb-jit.cc
diff --git a/src/gdb-jit.cc b/src/gdb-jit.cc
index dde6bbdaad4e2ca4fd095040e341fc406ce0e86d..29ce9842134d245c6cb7e87ff654a82037a02007 100644
--- a/src/gdb-jit.cc
+++ b/src/gdb-jit.cc
@@ -852,9 +852,9 @@ class ELFSymbol BASE_EMBEDDED {
};
-class ELFSymbolTable : public ELFSection {
+class ELFStringTable : public ELFSection {
Yang 2013/02/11 12:26:36 I was thinking that this use of "symbol" has nothi
rossberg 2013/02/11 13:30:16 Indeed, reverted.
public:
- ELFSymbolTable(const char* name, Zone* zone)
+ ELFStringTable(const char* name, Zone* zone)
: ELFSection(name, TYPE_SYMTAB, sizeof(uintptr_t)),
locals_(1, zone),
globals_(1, zone) {
@@ -1022,7 +1022,7 @@ static void CreateSymbolsTable(CodeDescription* desc,
ELF* elf,
int text_section_index) {
Zone* zone = desc->info()->zone();
- ELFSymbolTable* symtab = new(zone) ELFSymbolTable(".symtab", zone);
+ ELFStringTable* symtab = new(zone) ELFStringTable(".symtab", zone);
StringTable* strtab = new(zone) StringTable(".strtab");
// Symbol table should be followed by the linked string table.

Powered by Google App Engine
This is Rietveld 408576698