Renamed "symbols" to "internalized strings" throughout the code base,

src/gdb-jit.cc

 // Copyright 2010 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 834 matching lines @@
  private:
   const char* name;
   uintptr_t value;
   uintptr_t size;
   uint8_t info;
   uint8_t other;
   uint16_t section;
 };
 
 
-class ELFSymbolTable : public ELFSection {
+class ELFStringTable : public ELFSection {

[Yang, 2013/02/11 12:26:36]

I was thinking that this use of "symbol" has nothing to do with V8... and you
didn't change the ELFSymbol class, so changing this here makes little sense.

[rossberg, 2013/02/11 13:30:16]

Indeed, reverted.

  public:
-  ELFSymbolTable(const char* name, Zone* zone)
+  ELFStringTable(const char* name, Zone* zone)
       : ELFSection(name, TYPE_SYMTAB, sizeof(uintptr_t)),
         locals_(1, zone),
         globals_(1, zone) {
   }
 
   virtual void WriteBody(Writer::Slot<Header> header, Writer* w) {
     w->Align(header->alignment);
     int total_symbols = locals_.length() + globals_.length() + 1;
     header->offset = w->position();
 
@@ skipping 147 matching lines @@
 #ifdef V8_TARGET_ARCH_X64
   uintptr_t stack_state_start_addresses_[STACK_STATE_MAX];
 #endif
 };
 
 #if defined(__ELF)
 static void CreateSymbolsTable(CodeDescription* desc,
                                ELF* elf,
                                int text_section_index) {
   Zone* zone = desc->info()->zone();
-  ELFSymbolTable* symtab = new(zone) ELFSymbolTable(".symtab", zone);
+  ELFStringTable* symtab = new(zone) ELFStringTable(".symtab", zone);
   StringTable* strtab = new(zone) StringTable(".strtab");
 
   // Symbol table should be followed by the linked string table.
   elf->AddSection(symtab, zone);
   elf->AddSection(strtab, zone);
 
   symtab->Add(ELFSymbol("V8 Code",
                         0,
                         0,
                         ELFSymbol::BIND_LOCAL,
@@ skipping 1128 matching lines @@
   ScopedLock lock(mutex.Pointer());
   ASSERT(!IsLineInfoTagged(line_info));
   HashMap::Entry* e = GetEntries()->Lookup(code, HashForCodeObject(code), true);
   ASSERT(e->value == NULL);
   e->value = TagLineInfo(line_info);
 }
 
 
 } }  // namespace v8::internal
 #endif