Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12210057: Added temporary #ifdefs to support incompatible ANGLE API upgrade. (Closed)

Created:
7 years, 10 months ago by Ken Russell (switch to Gerrit)
Modified:
7 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, apatrick_chromium, Zhenyao Mo, alokp, jschuh
Visibility:
Public.

Description

Added temporary #ifdefs to support incompatible ANGLE API upgrade. BUG=174821 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181964

Patch Set 1 #

Patch Set 2 : Renamed SH_VERSION macro due to conflict on Android bot. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -9 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/shader_translator.cc View 1 5 chunks +15 lines, -9 lines 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_impl.cc View 1 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Ken Russell (switch to Gerrit)
7 years, 10 months ago (2013-02-07 03:43:29 UTC) #1
jschuh
lgtm on the security side.
7 years, 10 months ago (2013-02-07 14:18:17 UTC) #2
apatrick_chromium
lgtm
7 years, 10 months ago (2013-02-11 20:29:03 UTC) #3
greggman
lgtm
7 years, 10 months ago (2013-02-11 21:37:31 UTC) #4
Ken Russell (switch to Gerrit)
The WebKit change necessary to support this ANGLE upgrade just landed (http://trac.webkit.org/changeset/142567), so I'm proceeding ...
7 years, 10 months ago (2013-02-12 03:07:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kbr@chromium.org/12210057/5001
7 years, 10 months ago (2013-02-12 03:09:17 UTC) #6
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=98482
7 years, 10 months ago (2013-02-12 05:04:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kbr@chromium.org/12210057/5001
7 years, 10 months ago (2013-02-12 05:10:29 UTC) #8
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=98556
7 years, 10 months ago (2013-02-12 07:50:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kbr@chromium.org/12210057/5001
7 years, 10 months ago (2013-02-12 08:05:44 UTC) #10
commit-bot: I haz the power
7 years, 10 months ago (2013-02-12 10:23:10 UTC) #11 
Retried try job too often on mac_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698