Fix page jumping back to initial position after an overflow-bounce scroll.

Fix page jumping back to initial position after an overflow-bounce scroll.

Merges http://trac.webkit.org/changeset/160791 and
http://trac.webkit.org/changeset/160898 from Beth Dakin <bdakin@apple.com>;.

BUG=330887
TEST=Do a two-finger scroll at 45 degrees scrolling down and right on the right
page edge.  Prior to this patch, this would scroll down and overscroll-bounce
to the right, and at the end of the scroll the page would jump back to where
the scroll started. With this patch, no jumping occurs.
(Also see bug.)

[Nico, 2013-12-28 19:25:27]

This is where you get to say "test?" :-) If you do that, I'd be happy about
hints on how to write a test (if you have any – if not, I'll figure it out)

[Alexei Svitkine (slow), 2014-01-06 19:45:17]

Change looks good.

As for testing it, perhaps something similar to this test would work:

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

[Alexei Svitkine (slow), 2014-01-15 17:52:05]

On 2014/01/06 19:45:17, Alexei Svitkine wrote:
> Change looks good.
> 
> As for testing it, perhaps something similar to this test would work:
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

Wondering what's the status of this - I guess you've just not had time to look
at making a test for it?

[Nico, 2014-01-15 17:52:35]

On Wed, Jan 15, 2014 at 9:52 AM, <asvitkine@chromium.org> wrote:

> On 2014/01/06 19:45:17, Alexei Svitkine wrote:
>
>> Change looks good.
>>
>
>  As for testing it, perhaps something similar to this test would work:
>>
>
>
> https://code.google.com/p/chromium/codesearch#chromium/
> src/third_party/WebKit/LayoutTests/rubberbanding/momentum-reset.html
>
> Wondering what's the status of this - I guess you've just not had time to
> look
> at making a test for it?
>

Yup, sorry. Will get around to it eventually.


>
> https://codereview.chromium.org/122093002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[Alexei Svitkine (slow), 2014-01-15 17:54:55]

np, just making sure it doesn't get forgotten


On Wed, Jan 15, 2014 at 12:52 PM, Nico Weber <thakis@chromium.org> wrote:

> On Wed, Jan 15, 2014 at 9:52 AM, <asvitkine@chromium.org> wrote:
>
>> On 2014/01/06 19:45:17, Alexei Svitkine wrote:
>>
>>> Change looks good.
>>>
>>
>>  As for testing it, perhaps something similar to this test would work:
>>>
>>
>>
>> https://code.google.com/p/chromium/codesearch#chromium/
>> src/third_party/WebKit/LayoutTests/rubberbanding/momentum-reset.html
>>
>> Wondering what's the status of this - I guess you've just not had time to
>> look
>> at making a test for it?
>>
>
> Yup, sorry. Will get around to it eventually.
>
>
>>
>> https://codereview.chromium.org/122093002/
>>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[erikchen, 2014-05-13 04:07:13]

I fixed the unit test to correctly differentiate between the broken and correct
behaviors.

CL at https://codereview.chromium.org/282743002/. I will clean up the CL and
send it out for review tomorrow.

[eseidel, 2014-05-29 00:12:19]

This CL does not look ready for review. (maybe it was intended as a WIP?)

https://codereview.chromium.org/122093002/diff/110001/LayoutTests/rubberbandi...
File LayoutTests/rubberbanding/scroll-bounce-fix.html (right):

https://codereview.chromium.org/122093002/diff/110001/LayoutTests/rubberbandi...
LayoutTests/rubberbanding/scroll-bounce-fix.html:30:
//testRunner.waitUntilDone();
Did you mean to comment out this code?

https://codereview.chromium.org/122093002/diff/110001/Source/platform/mac/Scr...
File Source/platform/mac/ScrollElasticityController.mm (right):

https://codereview.chromium.org/122093002/diff/110001/Source/platform/mac/Scr...
Source/platform/mac/ScrollElasticityController.mm:360:
//m_client->adjustScrollPositionToBoundsIfNecessary();
Commented out code..??

https://codereview.chromium.org/122093002/diff/110001/Source/platform/mac/Scr...
Source/platform/mac/ScrollElasticityController.mm:361:
m_client->immediateScrollBy(m_origOrigin - m_client->absoluteScrollPosition());
Bad indent??

[erikchen, 2014-05-29 00:20:35]

This CL should be closed. I've forked the CL, and already landed the forked
change at:

https://codereview.chromium.org/282743002/