Source/platform/mac/ScrollElasticityController.mm - Issue 122093002: Fix page jumping back to initial position after an overflow-bounce scroll.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/mac/ScrollElasticityController.mm

Issue 122093002: Fix page jumping back to initial position after an overflow-bounce scroll. Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: does not fail :-/ Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/mac/ScrollElasticityController.mm

diff --git a/Source/platform/mac/ScrollElasticityController.mm b/Source/platform/mac/ScrollElasticityController.mm

index 0ab305b6ab91823e3ff09e4e30feebf082a77ac4..49f6a891f91288ceb2b508b82066c44434ed09ee 100644

--- a/Source/platform/mac/ScrollElasticityController.mm

+++ b/Source/platform/mac/ScrollElasticityController.mm

@@ -357,7 +357,8 @@ void ScrollElasticityController::snapRubberBandTimerFired()

m_stretchScrollForce.setWidth(reboundDeltaForElasticDelta(newStretch.width()));

m_stretchScrollForce.setHeight(reboundDeltaForElasticDelta(newStretch.height()));

} else {

- m_client->immediateScrollBy(m_origOrigin - m_client->absoluteScrollPosition());

+ //m_client->adjustScrollPositionToBoundsIfNecessary();

eseidel 2014/05/29 00:12:20 Commented out code..??

+m_client->immediateScrollBy(m_origOrigin - m_client->absoluteScrollPosition());

eseidel 2014/05/29 00:12:20 Bad indent??

stopSnapRubberbandTimer();

m_stretchScrollForce = FloatSize();