Add a policy and pref to control whether deleting browsing and download history is allowed.

Add a policy and pref to control whether deleting browsing and download history is allowed.

The policy is currently disabled (by saying that it is supported on no platforms), pending a UI treatment that allows users to know when deleting browsing history is prohibited.

TBR=rlp@chromium.org

BUG=175419
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182233

[Pam (message me for reviews), 2013-02-11 15:26:18]

Hi João,

Please take a look. Thanks!

- Pam

[Joao da Silva, 2013-02-11 15:48:52]

lgtm after adding the 'future' field.

https://codereview.chromium.org/12209091/diff/1/chrome/app/policy/policy_temp...
File chrome/app/policy/policy_templates.json (right):

https://codereview.chromium.org/12209091/diff/1/chrome/app/policy/policy_temp...
chrome/app/policy/policy_templates.json:440: 'name':
'DeletingBrowserHistoryEnabled',
Suggestion: I'm not a native English speaker, so your call on this one :-) Do
you think "AllowDeletingBrowserHistory" is more clear?

https://codereview.chromium.org/12209091/diff/1/chrome/app/policy/policy_temp...
chrome/app/policy/policy_templates.json:440: 'name':
'DeletingBrowserHistoryEnabled',
Set 'future': True for this policy.

[Pam (message me for reviews), 2013-02-12 13:58:20]

Please take another look, particularly in reply to the naming question. Thanks.

https://codereview.chromium.org/12209091/diff/1/chrome/app/policy/policy_temp...
File chrome/app/policy/policy_templates.json (right):

https://codereview.chromium.org/12209091/diff/1/chrome/app/policy/policy_temp...
chrome/app/policy/policy_templates.json:440: 'name':
'DeletingBrowserHistoryEnabled',
On 2013/02/11 15:48:52, Joao da Silva wrote:
> Suggestion: I'm not a native English speaker, so your call on this one :-) Do
> you think "AllowDeletingBrowserHistory" is more clear?

It would be. Which is more important, that or matching
"SavingBrowserHistoryDisabled"?

https://codereview.chromium.org/12209091/diff/1/chrome/app/policy/policy_temp...
chrome/app/policy/policy_templates.json:440: 'name':
'DeletingBrowserHistoryEnabled',
On 2013/02/11 15:48:52, Joao da Silva wrote:
> Set 'future': True for this policy.

Done.

[Joao da Silva, 2013-02-12 14:04:25]

https://codereview.chromium.org/12209091/diff/1/chrome/app/policy/policy_temp...
File chrome/app/policy/policy_templates.json (right):

https://codereview.chromium.org/12209091/diff/1/chrome/app/policy/policy_temp...
chrome/app/policy/policy_templates.json:440: 'name':
'DeletingBrowserHistoryEnabled',
On 2013/02/12 13:58:20, Pam wrote:
> On 2013/02/11 15:48:52, Joao da Silva wrote:
> > Suggestion: I'm not a native English speaker, so your call on this one :-)
Do
> > you think "AllowDeletingBrowserHistory" is more clear?
> 
> It would be. Which is more important, that or matching
> "SavingBrowserHistoryDisabled"?

That policy has negative polarity, which is a source of a lot of confusion and
we try to avoid that from now on. I'd go for a clearer name than consistency
with broken naming.

[Pam (message me for reviews), 2013-02-13 11:48:44]

Renamed and committed.

TBR=rlp, please give owner approval for browser/profiles/

Thanks,
- Pam

[Pam (message me for reviews), 2013-02-13 11:49:21]

TBR ping for rlp

[commit-bot: I haz the power, 2013-02-13 11:53:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pam@chromium.org/12209091/9004

[commit-bot: I haz the power, 2013-02-13 15:54:28]

Change committed as 182233

[rpetterson, 2013-02-13 19:01:00]

Profile LGTM (for good measure)