Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 12209071: Add temporary FilterType default branches in preparation of FilterTypeSaturatingBrightness (Closed)

Created:
7 years, 10 months ago by fmalita_google_do_not_use
Modified:
7 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, cc-bugs_chromium.org, jam
Visibility:
Public.

Description

Add temporary FilterType default branches in preparation of FilterTypeSaturatingBrightness To prevent compile warnings (treated as errors) when the new FilterType lands in WK, this patch adds temporary default branches to ParamTraits<WebKit::WebFilterOperation>::*. R=senorblanco@google.com BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181742

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M content/common/cc_messages.cc View 3 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
fmalita_google_do_not_use
7 years, 10 months ago (2013-02-08 20:51:23 UTC) #1
Stephen White
On 2013/02/08 20:51:23, fmalita wrote: LGTM (although you'll probably need an OWNER).
7 years, 10 months ago (2013-02-08 20:53:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fmalita@google.com/12209071/1
7 years, 10 months ago (2013-02-08 20:53:54 UTC) #3
commit-bot: I haz the power
Presubmit check for 12209071-1 failed and returned exit status 1. INFO:root:Found 1 file(s). Running presubmit ...
7 years, 10 months ago (2013-02-08 20:53:56 UTC) #4
fmalita_google_do_not_use
Chris, Julien - can you please take a look at this?
7 years, 10 months ago (2013-02-08 22:02:40 UTC) #5
jln (very slow on Chromium)
Hi, we're owner in content/common for the Linux sandbox. Please, get an OWNER of content/ ...
7 years, 10 months ago (2013-02-09 04:52:19 UTC) #6
piman
LGTM, just make sure to revert (TBR=me) after the WK change has rolled.
7 years, 10 months ago (2013-02-11 19:58:16 UTC) #7
danakj
You'll need a security review for *_messages.cc file changes (see the OWNERS file)
7 years, 10 months ago (2013-02-11 21:34:33 UTC) #8
fmalita_google_do_not_use
On 2013/02/11 21:34:33, danakj wrote: > You'll need a security review for *_messages.cc file changes ...
7 years, 10 months ago (2013-02-11 22:58:09 UTC) #9
danakj
7 years, 10 months ago (2013-02-11 23:14:41 UTC) #10
On Mon, Feb 11, 2013 at 2:58 PM, <fmalita@google.com> wrote:

> On 2013/02/11 21:34:33, danakj wrote:
>
>> You'll need a security review for *_messages.cc file changes (see the
>> OWNERS
>> file)
>>
>
> Hmm, I can only see *_messages.h entries in the OWNERS file (for IPC
> message
> changes) - am I missing something?
>

Oh okay, I must have misremembered, please ignore :) The bot will warn with
more accuracy than I will heh.

Powered by Google App Engine
This is Rietveld 408576698