LayoutTests/fast/forms/ValidityState-customError.html - Issue 1220833002: Make the setCustomValidity() error argument not nullable

Unified Diff: LayoutTests/fast/forms/ValidityState-customError.html

Issue 1220833002: Make the setCustomValidity() error argument not nullable (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/dom/setCustomValidity-validationMessage.html ('K') | « LayoutTests/fast/dom/setCustomValidity-validationMessage-expected.txt ('k') | LayoutTests/fast/forms/ValidityState-customError-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/forms/ValidityState-customError.html

diff --git a/LayoutTests/fast/forms/ValidityState-customError.html b/LayoutTests/fast/forms/ValidityState-customError.html

index 3765a89351611e654aaf05d0e629c5e3c9a72621..ea7a3a1a22c2e2c818679994224bceada5721b19 100644

--- a/LayoutTests/fast/forms/ValidityState-customError.html

+++ b/LayoutTests/fast/forms/ValidityState-customError.html

@@ -105,13 +105,13 @@ for (i = 0; i < v.length; i++) {

v[i].setCustomValidity(undefined);

}

shouldBeFalse('customErrorFor("fieldset-many-changes")');

philipj_slow 2015/07/07 11:48:52 Do you know why <fieldset> and <button> are behavi

tkent 2015/07/08 00:31:06 <fieldset> is not a candidate for constraint valid

philipj_slow 2015/07/08 08:08:46 Interesting, looks like HTMLFieldset.setCustomVali

-shouldBeFalse('customErrorFor("button-many-changes")');

+shouldBeTrue('customErrorFor("button-many-changes")');

shouldBeFalse('customErrorFor("button-button-many-changes")');

shouldBeFalse('customErrorFor("button-reset-many-changes")');

-shouldBeFalse('customErrorFor("select-many-changes")');

-shouldBeFalse('customErrorFor("textarea-many-changes")');

-shouldBeFalse('customErrorFor("input-many-changes")');

-shouldBeFalse('customErrorFor("input-submit-many-changes")');

+shouldBeTrue('customErrorFor("select-many-changes")');

+shouldBeTrue('customErrorFor("textarea-many-changes")');

+shouldBeTrue('customErrorFor("input-many-changes")');

+shouldBeTrue('customErrorFor("input-submit-many-changes")');

debug('Set with three arguments.');

for (i = 0; i < v.length; i++)

@@ -143,13 +143,13 @@ for (i = 0; i < v.length; i++) {