Chromium Code Reviews Chromium Code Reviews
Issue 1220833002:
Make the setCustomValidity() error argument not nullable (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| Index: LayoutTests/fast/dom/setCustomValidity-validationMessage.html |
| diff --git a/LayoutTests/fast/dom/setCustomValidity-validationMessage.html b/LayoutTests/fast/dom/setCustomValidity-validationMessage.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..9567a27b1b47f30f425bcd9193060baa9cd7066e |
| --- /dev/null |
| +++ b/LayoutTests/fast/dom/setCustomValidity-validationMessage.html |
| @@ -0,0 +1,91 @@ |
| +<!DOCTYPE HTML> |
| +<html> |
| +<head> |
| +<script src="../../resources/js-test.js"></script> |
| +</head> |
| +<body> |
| +<script> |
| +description('Test how setCustomValidity.validationMessage reacts to too few arguments.'); |
|
philipj_slow
2015/07/07 11:48:52
There's a separate test for that, this should be p
|
| + |
| +var b = document.createElement('button'); |
| +shouldThrow("b.setCustomValidity()"); |
| +shouldBeEqualToString('b.validationMessage', ''); |
| +b.setCustomValidity(null); |
| +shouldBeNull(b.validationMessage); |
|
philipj_slow
2015/07/07 11:48:52
That seems wrong, b.validationMessage should be th
|
| +b.setCustomValidity(''); |
| +shouldBeEqualToString('b.validationMessage', ''); |
| +b.setCustomValidity(undefined); |
| +shouldBeUndefined(b.validationMessage); |
|
philipj_slow
2015/07/07 11:48:52
Ditto.
|
| + |
| +var fs = document.createElement('fieldset'); |
| +shouldThrow("fs.setCustomValidity()"); |
| +shouldBeEqualToString('fs.validationMessage', ''); |
| +fs.setCustomValidity(null); |
| +shouldBeUndefined(fs.validationMessage); |
| +fs.setCustomValidity(''); |
| +shouldBeEqualToString('fs.validationMessage', ''); |
| +fs.setCustomValidity(undefined); |
| +shouldBeUndefined(fs.validationMessage); |
| + |
| +var i = document.createElement('input'); |
| +shouldThrow("i.setCustomValidity()"); |
| +shouldBeEqualToString('i.validationMessage', ''); |
| +i.setCustomValidity(null); |
| +shouldBeNull(i.validationMessage); |
| +i.setCustomValidity(''); |
| +shouldBeEqualToString('i.validationMessage', ''); |
| +i.setCustomValidity(undefined); |
| +shouldBeUndefined(i.validationMessage); |
| + |
| +var k = document.createElement('keygen'); |
| +shouldThrow("k.setCustomValidity()"); |
| +shouldBeEqualToString('k.validationMessage', ''); |
| +k.setCustomValidity(null); |
| +shouldBeUndefined(k.validationMessage); |
| +k.setCustomValidity(''); |
| +shouldBeEqualToString('k.validationMessage', ''); |
| +k.setCustomValidity(undefined); |
| +shouldBeUndefined(k.validationMessage); |
| + |
| +var ob = document.createElement('object'); |
| +shouldThrow("ob.setCustomValidity()"); |
| +shouldBeEqualToString('ob.validationMessage', ''); |
| +ob.setCustomValidity(null); |
| +shouldBeUndefined(ob.validationMessage); |
| +ob.setCustomValidity(''); |
| +shouldBeEqualToString('ob.validationMessage', ''); |
| +ob.setCustomValidity(undefined); |
| +shouldBeUndefined(ob.validationMessage); |
| + |
| +var ou = document.createElement('output'); |
| +shouldThrow("ou.setCustomValidity()"); |
| +shouldBeEqualToString('ou.validationMessage', ''); |
| +ou.setCustomValidity(null); |
| +shouldBeUndefined(ou.validationMessage); |
| +ou.setCustomValidity(''); |
| +shouldBeEqualToString('ou.validationMessage', ''); |
| +ou.setCustomValidity(undefined); |
| +shouldBeUndefined(ou.validationMessage); |
| + |
| +var s = document.createElement('select'); |
| +shouldThrow("s.setCustomValidity()"); |
| +shouldBeEqualToString('s.validationMessage', ''); |
| +s.setCustomValidity(null); |
| +shouldBeNull(s.validationMessage); |
| +s.setCustomValidity(''); |
| +shouldBeEqualToString('s.validationMessage', ''); |
| +s.setCustomValidity(undefined); |
| +shouldBeUndefined(s.validationMessage); |
| + |
| +var ta = document.createElement('textarea'); |
| +shouldThrow("ta.setCustomValidity()"); |
| +shouldBeEqualToString('ta.validationMessage', ''); |
| +ta.setCustomValidity(null); |
| +shouldBeNull(ta.validationMessage); |
| +ta.setCustomValidity(''); |
| +shouldBeEqualToString('ta.validationMessage', ''); |
| +ta.setCustomValidity(undefined); |
| +shouldBeUndefined(ta.validationMessage); |
| +</script> |
| +</body> |
| +</html> |
