LayoutTests/fast/dom/setCustomValidity-validationMessage.html - Issue 1220833002: Make the setCustomValidity() error argument not nullable

Side by Side Diff: LayoutTests/fast/dom/setCustomValidity-validationMessage.html

Issue 1220833002: Make the setCustomValidity() error argument not nullable (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>

	2 <html>

	3 <head>

	4 <script src="../../resources/js-test.js"></script>

	5 </head>

	6 <body>

	7 <script>

	8 description('Test how setCustomValidity.validationMessage reacts to too few argu ments.');
	philipj_slow 2015/07/07 11:48:52 There's a separate test for that, this should be p There's a separate test for that, this should be primarily about null and undefined, so maybe setCustomValidity-null-undefined.html and a description to match. Even better if this is written using testharness.js with a single generic bit of test code applied to all elements types, similar to https://codereview.chromium.org/1085843002/
	9

	10 var b = document.createElement('button');

	11 shouldThrow("b.setCustomValidity()");

	12 shouldBeEqualToString('b.validationMessage', '');

	13 b.setCustomValidity(null);

	14 shouldBeNull(b.validationMessage);
	philipj_slow 2015/07/07 11:48:52 That seems wrong, b.validationMessage should be th That seems wrong, b.validationMessage should be the string "null" unless I'm missing something.
	15 b.setCustomValidity('');

	16 shouldBeEqualToString('b.validationMessage', '');

	17 b.setCustomValidity(undefined);

	18 shouldBeUndefined(b.validationMessage);
	philipj_slow 2015/07/07 11:48:52 Ditto. Ditto.
	19

	20 var fs = document.createElement('fieldset');

	21 shouldThrow("fs.setCustomValidity()");

	22 shouldBeEqualToString('fs.validationMessage', '');

	23 fs.setCustomValidity(null);

	24 shouldBeUndefined(fs.validationMessage);

	25 fs.setCustomValidity('');

	26 shouldBeEqualToString('fs.validationMessage', '');

	27 fs.setCustomValidity(undefined);

	28 shouldBeUndefined(fs.validationMessage);

	29

	30 var i = document.createElement('input');

	31 shouldThrow("i.setCustomValidity()");

	32 shouldBeEqualToString('i.validationMessage', '');

	33 i.setCustomValidity(null);

	34 shouldBeNull(i.validationMessage);

	35 i.setCustomValidity('');

	36 shouldBeEqualToString('i.validationMessage', '');

	37 i.setCustomValidity(undefined);

	38 shouldBeUndefined(i.validationMessage);

	39

	40 var k = document.createElement('keygen');

	41 shouldThrow("k.setCustomValidity()");

	42 shouldBeEqualToString('k.validationMessage', '');

	43 k.setCustomValidity(null);

	44 shouldBeUndefined(k.validationMessage);

	45 k.setCustomValidity('');

	46 shouldBeEqualToString('k.validationMessage', '');

	47 k.setCustomValidity(undefined);

	48 shouldBeUndefined(k.validationMessage);

	49

	50 var ob = document.createElement('object');

	51 shouldThrow("ob.setCustomValidity()");

	52 shouldBeEqualToString('ob.validationMessage', '');

	53 ob.setCustomValidity(null);

	54 shouldBeUndefined(ob.validationMessage);

	55 ob.setCustomValidity('');

	56 shouldBeEqualToString('ob.validationMessage', '');

	57 ob.setCustomValidity(undefined);

	58 shouldBeUndefined(ob.validationMessage);

	59

	60 var ou = document.createElement('output');

	61 shouldThrow("ou.setCustomValidity()");

	62 shouldBeEqualToString('ou.validationMessage', '');

	63 ou.setCustomValidity(null);

	64 shouldBeUndefined(ou.validationMessage);

	65 ou.setCustomValidity('');

	66 shouldBeEqualToString('ou.validationMessage', '');

	67 ou.setCustomValidity(undefined);

	68 shouldBeUndefined(ou.validationMessage);

	69

	70 var s = document.createElement('select');

	71 shouldThrow("s.setCustomValidity()");

	72 shouldBeEqualToString('s.validationMessage', '');

	73 s.setCustomValidity(null);

	74 shouldBeNull(s.validationMessage);

	75 s.setCustomValidity('');

	76 shouldBeEqualToString('s.validationMessage', '');

	77 s.setCustomValidity(undefined);

	78 shouldBeUndefined(s.validationMessage);

	79

	80 var ta = document.createElement('textarea');

	81 shouldThrow("ta.setCustomValidity()");

	82 shouldBeEqualToString('ta.validationMessage', '');

	83 ta.setCustomValidity(null);

	84 shouldBeNull(ta.validationMessage);

	85 ta.setCustomValidity('');

	86 shouldBeEqualToString('ta.validationMessage', '');

	87 ta.setCustomValidity(undefined);

	88 shouldBeUndefined(ta.validationMessage);

	89 </script>

	90 </body>

	91 </html>

OLD	NEW