LayoutTests/fast/dom/setAttributeNS.html - Issue 122083002: createElementNS handles element name 'xmlns' correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/dom/setAttributeNS.html

Issue 122083002: createElementNS handles element name 'xmlns' correctly. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressed feedback. Created 6 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dom/script-tests/setAttributeNS-prefix-and-null-namespace.js ('k') | LayoutTests/fast/dom/setAttributeNS-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/dom/setAttributeNS.html

diff --git a/LayoutTests/fast/dom/setAttributeNS.html b/LayoutTests/fast/dom/setAttributeNS.html

index 814fb0abc73f01afa91197013ba063a6ddd26b8d..8f974359e11cf733bd69ee0c4e1bfc5027ab40e7 100644

--- a/LayoutTests/fast/dom/setAttributeNS.html

+++ b/LayoutTests/fast/dom/setAttributeNS.html

@@ -1,32 +1,10 @@

-<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"

- "http://www.w3.org/TR/html4/loose.dtd">

-<html>

-<head>

-<script>

-function debug(str) {

- pre = document.getElementById('console');

- text = document.createTextNode(str + '\n');

- pre.appendChild(text);

-function runTests() {

- if (window.testRunner)

- testRunner.dumpAsText();

+<!DOCTYPE html>

+<script src="../../resources/js-test.js"></script>

- elem = document.createElementNS('http://www.example.org', 'test')

- attr = elem.setAttributeNS(null, 'name', 'value')

- if (elem.attributes[0].namespaceURI == null)

- debug('SUCCESS')

- else

- debug('FAILURE')

+<script>

+description("Test that setAttributeNS with a null namespaceURI actually sets it to the value null and not a string with the contents 'null'.");

+window.elem = document.createElementNS('http://www.example.org', 'test');

+elem.setAttributeNS(null, 'name', 'value');

+shouldBeNull('elem.attributes[0].namespaceURI');

</script>

-</head>

-<body onload="runTests();">

-This tests that setAttributeNS with a null namespaceURI actually sets it to the value null and not a string with the contents 'null'. If the test is sucessful, the text below should say "SUCCESS".

-<pre id="console">

-</pre>

-</body>

-</html>