createElementNS handles element name 'xmlns' correctly.

createElementNS handles element name 'xmlns' correctly.

This matches the behavior of Internet Explorer and Firefox, the DOM
Level 3 Core specification, and the DOM4 specification.

http://www.w3.org/TR/2004/REC-DOM-Level-3-Core-20040407/core.html#ID-DocCrElNS
http://www.w3.org/TR/dom/#dom-document-createelementns
http://w3c.github.io/dom/#dom-document-createelementns

BUG=330946
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164492

[pwnall-personal, 2013-12-28 20:44:00]

Please take a look?

[abarth-chromium, 2014-01-04 05:29:44]

Can you add information to the description about how this change aligns with the
specification and implementations in other browsers.  Presumably this change is
making us less like Safari, for example.

[pwnall-personal, 2014-01-04 07:26:20]

On 2014/01/04 05:29:44, abarth wrote:
> Can you add information to the description about how this change aligns with
the
> specification and implementations in other browsers.  Presumably this change
is
> making us less like Safari, for example.

Done. Can you please take another look?

I didn't mention Safari, again. This will make us deviate from WebKit/Safari,
but I plan to port the patch there as soon as it is accepted here.

[abarth-chromium, 2014-01-04 17:53:34]

LGTM

Thanks for the comparison with other browsers.

https://codereview.chromium.org/122083002/diff/40001/Source/core/dom/Document...
File Source/core/dom/Document.cpp (right):

https://codereview.chromium.org/122083002/diff/40001/Source/core/dom/Document...
Source/core/dom/Document.cpp:978: return true;
Can you change these last three lines to read:

return qName.namespaceURI() != XMLNSNames::xmlnsNamespaceURI;

That's clearer than an if statement that returns true or false.

[pwnall-personal, 2014-01-04 19:31:37]

Thank you for helping me making the code better!

https://codereview.chromium.org/122083002/diff/40001/Source/core/dom/Document...
File Source/core/dom/Document.cpp (right):

https://codereview.chromium.org/122083002/diff/40001/Source/core/dom/Document...
Source/core/dom/Document.cpp:978: return true;
On 2014/01/04 17:53:34, abarth wrote:
> Can you change these last three lines to read:
> 
> return qName.namespaceURI() != XMLNSNames::xmlnsNamespaceURI;
> 
> That's clearer than an if statement that returns true or false.

Done.

[commit-bot: I haz the power, 2014-01-04 19:32:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/costan@gmail.com/122083002/140001

[commit-bot: I haz the power, 2014-01-06 04:44:47]

Change committed as 164492