Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1017)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java

Issue 1220813010: Add UMA metrics to track the source of homescreen icons on launch. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing reviewer comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java b/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java
index 571f0a9aa52b86b0ab403bfbe8ee2877f69115ae..cca9297848252635aa9c07fbb3a4c559f6b8c9c4 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java
@@ -33,6 +33,10 @@ public class ShortcutHelper {
public static final String EXTRA_TITLE = "org.chromium.chrome.browser.webapp_title";
public static final String EXTRA_URL = "org.chromium.chrome.browser.webapp_url";
public static final String EXTRA_ORIENTATION = ScreenOrientationConstants.EXTRA_ORIENTATION;
+ public static final String EXTRA_SOURCE = "org.chromium.chrome.browser.webapp_source";
+
+ // This value is equal to SOURCE_UNKNOWN in the C++ ShortcutInfo struct.
+ public static final int SOURCE_UNKNOWN = 0;
/** Observes the data fetching pipeline. */
public interface ShortcutHelperObserver {
@@ -137,7 +141,7 @@ public class ShortcutHelper {
@SuppressWarnings("unused")
@CalledByNative
private static void addShortcut(Context context, String url, String title, Bitmap icon,
- boolean isWebappCapable, int orientation) {
+ boolean isWebappCapable, int orientation, int source) {
assert sFullScreenAction != null;
Intent shortcutIntent;
@@ -165,6 +169,9 @@ public class ShortcutHelper {
shortcutIntent = BookmarkUtils.createShortcutIntent(url);
}
+ // Always attach a source (one of add to homescreen menu item, app banner, or unknown) to
+ // the intent. This allows us to distinguish where a shortcut was added from in metrics.
+ shortcutIntent.putExtra(EXTRA_SOURCE, source);
shortcutIntent.setPackage(context.getPackageName());
context.sendBroadcast(
BookmarkUtils.createAddToHomeIntent(shortcutIntent, title, icon, url));

Powered by Google App Engine
This is Rietveld 408576698