chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java - Issue 1220813010: Add UMA metrics to track the source of homescreen icons on launch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

Issue 1220813010: Add UMA metrics to track the source of homescreen icons on launch. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing reviewer comments Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

index 5a604a4020517ff287cda8f068e70cc232e1f8f1..5b9b43f180c2574f212500442d7e55ef807f032f 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

@@ -612,7 +612,9 @@ public class ChromeTabbedActivity extends ChromeActivity implements ActionBarDel

launchIntent(url, referer, headers, externalAppId, true, intent);

}

RecordUserAction.record("MobileReceivedExternalIntent");

- LaunchMetrics.recordHomeScreenLaunchIntoTab(url);

+ int shortcutSource = intent.getIntExtra(

+ ShortcutHelper.EXTRA_SOURCE, ShortcutHelper.SOURCE_UNKNOWN);

+ LaunchMetrics.recordHomeScreenLaunchIntoTab(url, shortcutSource);

break;

case REUSE_APP_ID_MATCHING_TAB_ELSE_NEW_TAB:

launchIntent(url, referer, headers, externalAppId, false, intent);

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java » ('j') | no next file with comments »