chrome/browser/android/shortcut_helper.cc - Issue 1220813010: Add UMA metrics to track the source of homescreen icons on launch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/shortcut_helper.cc

Issue 1220813010: Add UMA metrics to track the source of homescreen icons on launch. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing reviewer comments Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/android/shortcut_helper.cc

diff --git a/chrome/browser/android/shortcut_helper.cc b/chrome/browser/android/shortcut_helper.cc

index fc46ef7806a72f2641b340c311679f0ad4ede12b..a151e211488f7cb441a4086a22492f44d6de615f 100644

--- a/chrome/browser/android/shortcut_helper.cc

+++ b/chrome/browser/android/shortcut_helper.cc

@@ -158,7 +158,8 @@ void ShortcutHelper::AddShortcutInBackgroundWithSkBitmap(

java_title.obj(),

java_bitmap.obj(),

info.display == content::Manifest::DISPLAY_MODE_STANDALONE,

- info.orientation);

+ info.orientation,

+ info.source);

}

void ShortcutHelper::RecordAddToHomescreen() {

« no previous file with comments | « chrome/browser/android/metrics/launch_metrics.cc ('k') | chrome/browser/android/shortcut_info.h » ('j') | no next file with comments »