Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2158)

Unified Diff: chrome/browser/android/metrics/launch_metrics.cc

Issue 1220813010: Add UMA metrics to track the source of homescreen icons on launch. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing reviewer comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/metrics/launch_metrics.cc
diff --git a/chrome/browser/android/metrics/launch_metrics.cc b/chrome/browser/android/metrics/launch_metrics.cc
index 5ae5968581829ab43e52fd172340441eccb6a70f..6abef98306b93fa348e9d164b48b26b6f7fb6b07 100644
--- a/chrome/browser/android/metrics/launch_metrics.cc
+++ b/chrome/browser/android/metrics/launch_metrics.cc
@@ -7,6 +7,7 @@
#include "base/android/jni_string.h"
#include "base/metrics/histogram_macros.h"
#include "base/metrics/user_metrics.h"
+#include "chrome/browser/android/shortcut_info.h"
#include "chrome/browser/banners/app_banner_settings_helper.h"
#include "chrome/browser/browser_process.h"
#include "components/rappor/rappor_utils.h"
@@ -27,12 +28,12 @@ bool RegisterLaunchMetrics(JNIEnv* env) {
}
static void RecordLaunch(JNIEnv* env, jclass caller, jboolean standalone,
- jstring jurl, jobject jweb_contents) {
+ jstring jurl, int source, jobject jweb_contents) {
GURL url(base::android::ConvertJavaStringToUTF8(env, jurl));
content::WebContents* web_contents =
content::WebContents::FromJavaWebContents(jweb_contents);
- if (web_contents) {
+ if (web_contents && source == ShortcutInfo::SOURCE_APP_BANNER) {
// What a user has installed on the Home screen can become disconnected from
// what Chrome believes is on the Home screen if the user clears their data.
// Use the launch as a signal that the shortcut still exists.
@@ -50,6 +51,9 @@ static void RecordLaunch(JNIEnv* env, jclass caller, jboolean standalone,
UMA_HISTOGRAM_ENUMERATION("Launch.HomeScreen", action,
HOME_SCREEN_LAUNCH_COUNT);
+ UMA_HISTOGRAM_ENUMERATION("Launch.HomeScreenSource", source,
+ ShortcutInfo::SOURCE_COUNT);
+
rappor::SampleDomainAndRegistryFromGURL(g_browser_process->rappor_service(),
rappor_metric, url);
}
« no previous file with comments | « chrome/browser/android/banners/app_banner_infobar_delegate_android.cc ('k') | chrome/browser/android/shortcut_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698