Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Issue 1220813005: Minor performance improvements to the LookupIterator (Closed)

Created:
5 years, 5 months ago by Toon Verwaest
Modified:
5 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Minor performance improvements to the LookupIterator This change changes bootstrapping semantics for intercepted global objects. Unlike before, we'll now also call into the interceptor during bootstrapping. This affects properties loaded from within the runtime, such as global.Array and global.Symbol. The embedder will need to make sure that those values are the expected values during bootstrapping. BUG=chromium:505998 LOG=n Committed: https://crrev.com/5c278f632cafd0e20b960481553ece017de5da19 Cr-Commit-Position: refs/heads/master@{#29414}

Patch Set 1 #

Patch Set 2 : Update tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -13 lines) Patch
M src/lookup.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/lookup.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/lookup-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 1 chunk +5 lines, -4 lines 0 comments Download
M test/cctest/test-decls.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Toon Verwaest
ptal
5 years, 5 months ago (2015-07-01 11:49:14 UTC) #2
Jakob Kummerow
lgtm
5 years, 5 months ago (2015-07-01 11:50:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1220813005/20001
5 years, 5 months ago (2015-07-01 11:52:13 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-01 12:20:00 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-01 12:20:23 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5c278f632cafd0e20b960481553ece017de5da19
Cr-Commit-Position: refs/heads/master@{#29414}

Powered by Google App Engine
This is Rietveld 408576698