src/lookup-inl.h - Issue 1220813005: Minor performance improvements to the LookupIterator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/lookup-inl.h

Issue 1220813005: Minor performance improvements to the LookupIterator (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Update tests Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/lookup-inl.h

diff --git a/src/lookup-inl.h b/src/lookup-inl.h

index 98971390b60e1dd8674670ffa326f4546b978997..9b5927b53c3207ecf790e392f655835ed349fb81 100644

--- a/src/lookup-inl.h

+++ b/src/lookup-inl.h

@@ -15,7 +15,7 @@ namespace internal {

JSReceiver* LookupIterator::NextHolder(Map* map) {

DisallowHeapAllocation no_gc;

- if (map->prototype()->IsNull()) return NULL;

+ if (!map->prototype()->IsJSReceiver()) return NULL;

JSReceiver* next = JSReceiver::cast(map->prototype());

DCHECK(!next->map()->IsGlobalObjectMap() ||

« no previous file with comments | « src/lookup.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »