Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: extensions/renderer/dispatcher.cc

Issue 1220813003: Fix flakiness and re-enable FormAutocompleteTest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove "Flaky" comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/autofill/form_autocomplete_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/dispatcher.cc
diff --git a/extensions/renderer/dispatcher.cc b/extensions/renderer/dispatcher.cc
index 66ffdcfa9d3ed41c801c351eb6933b20543c229c..5e29617847d58f99d3c47cdfeeb7349ed819efc8 100644
--- a/extensions/renderer/dispatcher.cc
+++ b/extensions/renderer/dispatcher.cc
@@ -361,7 +361,12 @@ void Dispatcher::DidCreateDocumentElement(blink::WebLocalFrame* frame) {
.as_string()));
}
- content_watcher_->DidCreateDocumentElement(frame);
+ // In testing, the document lifetime events can happen after the render
+ // process shutdown event.
+ // See: http://crbug.com/21508 and http://crbug.com/500851
+ if (content_watcher_) {
+ content_watcher_->DidCreateDocumentElement(frame);
+ }
}
void Dispatcher::OnExtensionResponse(int request_id,
« no previous file with comments | « chrome/renderer/autofill/form_autocomplete_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698