chrome/renderer/autofill/form_autocomplete_browsertest.cc - Issue 1220813003: Fix flakiness and re-enable FormAutocompleteTest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/autofill/form_autocomplete_browsertest.cc

Issue 1220813003: Fix flakiness and re-enable FormAutocompleteTest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove "Flaky" comments Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/autofill/form_autocomplete_browsertest.cc

diff --git a/chrome/renderer/autofill/form_autocomplete_browsertest.cc b/chrome/renderer/autofill/form_autocomplete_browsertest.cc

index ec161322f24255b021d2add576679f7cf553c88b..1a88f8d572060f43ec9c727862d10ac0640ac148 100644

--- a/chrome/renderer/autofill/form_autocomplete_browsertest.cc

+++ b/chrome/renderer/autofill/form_autocomplete_browsertest.cc

@@ -68,8 +68,7 @@ void VerifyReceivedRendererMessages(content::MockRenderThread* render_thread,

// Tests that submitting a form generates WillSubmitForm and FormSubmitted

// messages with the form fields.

-// Flaky: http://crbug.com/500851.

-TEST_F(FormAutocompleteTest, DISABLED_NormalFormSubmit) {

+TEST_F(FormAutocompleteTest, NormalFormSubmit) {

// Load a form.

LoadHTML("<html><form id='myForm'><input name='fname' value='Rick'/>"

"<input name='lname' value='Deckard'/></form></html>");

@@ -104,8 +103,7 @@ TEST_F(FormAutocompleteTest, SubmitEventPrevented) {

// Tests that submitting a form that has autocomplete="off" generates

// WillSubmitForm and FormSubmitted messages.

-// Flaky: http://crbug.com/500851.

-TEST_F(FormAutocompleteTest, DISABLED_AutoCompleteOffFormSubmit) {

+TEST_F(FormAutocompleteTest, AutoCompleteOffFormSubmit) {

// Load a form.

LoadHTML("<html><form id='myForm' autocomplete='off'>"

"<input name='fname' value='Rick'/>"

@@ -121,8 +119,7 @@ TEST_F(FormAutocompleteTest, DISABLED_AutoCompleteOffFormSubmit) {

}

// Tests that fields with autocomplete off are submitted.

-// Flaky: http://crbug.com/500851.

-TEST_F(FormAutocompleteTest, DISABLED_AutoCompleteOffInputSubmit) {

+TEST_F(FormAutocompleteTest, AutoCompleteOffInputSubmit) {

// Load a form.

LoadHTML("<html><form id='myForm'>"

"<input name='fname' value='Rick'/>"

@@ -140,8 +137,7 @@ TEST_F(FormAutocompleteTest, DISABLED_AutoCompleteOffInputSubmit) {

// Tests that submitting a form that has been dynamically set as autocomplete

// off generates WillSubmitForm and FormSubmitted messages.

// Note: We previously did the opposite, for bug http://crbug.com/36520

-// Flaky: http://crbug.com/500851.

-TEST_F(FormAutocompleteTest, DISABLED_DynamicAutoCompleteOffFormSubmit) {

+TEST_F(FormAutocompleteTest, DynamicAutoCompleteOffFormSubmit) {

LoadHTML("<html><form id='myForm'><input name='fname' value='Rick'/>"

"<input name='lname' value='Deckard'/></form></html>");

« no previous file with comments | « no previous file | extensions/renderer/dispatcher.cc » ('j') | no next file with comments »