chrome/service/cloud_print/printer_job_handler.h - Issue 12208089: Changing CloudPrintURLFetcher instantiation to be more testable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/service/cloud_print/printer_job_handler.h

Issue 12208089: Changing CloudPrintURLFetcher instantiation to be more testable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/service/cloud_print/printer_job_handler.h

diff --git a/chrome/service/cloud_print/printer_job_handler.h b/chrome/service/cloud_print/printer_job_handler.h

index 9090ca388dcdcf42674cb02e338192bb8c4843ab..2a97fd65615fae723ec4919006bdd7d8bb024d6b 100644

--- a/chrome/service/cloud_print/printer_job_handler.h

+++ b/chrome/service/cloud_print/printer_job_handler.h

@@ -145,7 +145,9 @@ class PrinterJobHandler : public base::RefCountedThreadSafe<PrinterJobHandler>,

virtual void OnJobSpoolFailed() OVERRIDE;

// End Delegate implementations

+ protected:

+ virtual ~PrinterJobHandler();

+ virtual CloudPrintURLFetcher* CreateCloudPrintURLFetcher();

Vitaly Buka (NO REVIEWS) 2013/02/08 22:38:56 empty line before private

private:

friend class base::RefCountedThreadSafe<PrinterJobHandler>;

@@ -181,7 +183,7 @@ class PrinterJobHandler : public base::RefCountedThreadSafe<PrinterJobHandler>,

std::vector<std::string> tags_;

};

- virtual ~PrinterJobHandler();

// Begin request handlers for each state in the state machine

CloudPrintURLFetcher::ResponseAction HandlePrinterUpdateResponse(

« no previous file with comments | « no previous file | chrome/service/cloud_print/printer_job_handler.cc » ('j') | chrome/service/cloud_print/printer_job_handler.cc » ('J')