Changing CloudPrintURLFetcher instantiation to be more testable

chrome/service/cloud_print/printer_job_handler.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_SERVICE_CLOUD_PRINT_PRINTER_JOB_HANDLER_H_
 #define CHROME_SERVICE_CLOUD_PRINT_PRINTER_JOB_HANDLER_H_
 
 #include <list>
 #include <string>
 #include <vector>
@@ skipping 127 matching lines @@
   virtual void OnPrinterDeleted() OVERRIDE;
   virtual void OnPrinterChanged() OVERRIDE;
   virtual void OnJobChanged() OVERRIDE;
 
   // JobSpoolerDelegate implementation.
   // Called on print_thread_.
   virtual void OnJobSpoolSucceeded(const PlatformJobId& job_id) OVERRIDE;
   virtual void OnJobSpoolFailed() OVERRIDE;
 
   // End Delegate implementations
-
+ protected:
+  virtual ~PrinterJobHandler();
+  virtual CloudPrintURLFetcher* CreateCloudPrintURLFetcher();

[Vitaly Buka (NO REVIEWS), 2013/02/08 22:38:56]

empty line before private

  private:
   friend class base::RefCountedThreadSafe<PrinterJobHandler>;
 
   enum PrintJobError {
     SUCCESS,
     JOB_DOWNLOAD_FAILED,
     INVALID_JOB_DATA,
     PRINT_FAILED,
   };
 
@@ skipping 15 matching lines @@
     void Clear();
 
     std::string job_id_;
     std::string job_title_;
     std::string print_ticket_;
     FilePath print_data_file_path_;
     std::string print_data_mime_type_;
     std::vector<std::string> tags_;
   };
 
-  virtual ~PrinterJobHandler();
+
 
   // Begin request handlers for each state in the state machine
   CloudPrintURLFetcher::ResponseAction HandlePrinterUpdateResponse(
       const net::URLFetcher* source,
       const GURL& url,
       base::DictionaryValue* json_data,
       bool succeeded);
 
   CloudPrintURLFetcher::ResponseAction HandleJobMetadataResponse(
       const net::URLFetcher* source,
@@ skipping 111 matching lines @@
 
 // This typedef is to workaround the issue with certain versions of
 // Visual Studio where it gets confused between multiple Delegate
 // classes and gives a C2500 error. (I saw this error on the try bots -
 // the workaround was not needed for my machine).
 typedef PrinterJobHandler::Delegate PrinterJobHandlerDelegate;
 
 }  // namespace cloud_print
 
 #endif  // CHROME_SERVICE_CLOUD_PRINT_PRINTER_JOB_HANDLER_H_