Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Unified Diff: runtime/vm/flow_graph_optimizer.cc

Issue 12208046: Flip test condition when testing for fixed-length array length load. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_optimizer.cc
===================================================================
--- runtime/vm/flow_graph_optimizer.cc (revision 18168)
+++ runtime/vm/flow_graph_optimizer.cc (working copy)
@@ -555,7 +555,8 @@
}
if (!skip_check) {
// Insert array length load and bounds check.
- const bool is_immutable = (class_id != kGrowableObjectArrayCid);
+ const bool is_immutable =
+ CheckArrayBoundInstr::IsFixedLengthArrayType(class_id);
LoadFieldInstr* length = new LoadFieldInstr(
(*array)->Copy(),
CheckArrayBoundInstr::LengthOffsetFor(class_id),
@@ -1256,7 +1257,9 @@
return false;
}
const bool is_immutable =
- (recognized_kind != MethodRecognizer::kGrowableArrayLength);
+ (recognized_kind == MethodRecognizer::kObjectArrayLength) ||
+ (recognized_kind == MethodRecognizer::kImmutableArrayLength) ||
+ (recognized_kind == MethodRecognizer::kByteArrayBaseLength);
InlineArrayLengthGetter(call,
OffsetForLengthGetter(recognized_kind),
is_immutable,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698