Flip test condition when testing for fixed-length array length load.

runtime/vm/flow_graph_optimizer.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/flow_graph_optimizer.h"
 
 #include "vm/bit_vector.h"
 #include "vm/cha.h"
 #include "vm/flow_graph_builder.h"
 #include "vm/flow_graph_compiler.h"
@@ skipping 537 matching lines @@
     const ImmutableArray& constant_array =
         ImmutableArray::Cast(array_def->value());
     ConstantInstr* index_def = (*index)->definition()->AsConstant();
     if (index_def->value().IsSmi()) {
       intptr_t constant_index = Smi::Cast(index_def->value()).Value();
       skip_check = (constant_index < constant_array.Length());
     }
   }
   if (!skip_check) {
     // Insert array length load and bounds check.
-    const bool is_immutable = (class_id != kGrowableObjectArrayCid);
+    const bool is_immutable =
+        CheckArrayBoundInstr::IsFixedLengthArrayType(class_id);
     LoadFieldInstr* length = new LoadFieldInstr(
         (*array)->Copy(),
         CheckArrayBoundInstr::LengthOffsetFor(class_id),
         Type::ZoneHandle(Type::SmiType()),
         is_immutable);
     length->set_result_cid(kSmiCid);
     length->set_recognized_kind(
         LoadFieldInstr::RecognizedKindFromArrayCid(class_id));
     InsertBefore(call, length, NULL, Definition::kValue);
     InsertBefore(call,
@@ skipping 680 matching lines @@
   switch (recognized_kind) {
     case MethodRecognizer::kObjectArrayLength:
     case MethodRecognizer::kImmutableArrayLength:
     case MethodRecognizer::kByteArrayBaseLength:
     case MethodRecognizer::kGrowableArrayLength: {
       if (!ic_data.HasOneTarget()) {
         // TODO(srdjan): Implement for mutiple targets.
         return false;
       }
       const bool is_immutable =
-          (recognized_kind != MethodRecognizer::kGrowableArrayLength);
+          (recognized_kind == MethodRecognizer::kObjectArrayLength) ||
+          (recognized_kind == MethodRecognizer::kImmutableArrayLength) ||
+          (recognized_kind == MethodRecognizer::kByteArrayBaseLength);
       InlineArrayLengthGetter(call,
                               OffsetForLengthGetter(recognized_kind),
                               is_immutable,
                               recognized_kind);
       return true;
     }
     case MethodRecognizer::kGrowableArrayCapacity:
       InlineGrowableArrayCapacityGetter(call);
       return true;
     case MethodRecognizer::kStringBaseLength:
@@ skipping 3291 matching lines @@
 
   if (FLAG_trace_constant_propagation) {
     OS::Print("\n==== After constant propagation ====\n");
     FlowGraphPrinter printer(*graph_);
     printer.PrintBlocks();
   }
 }
 
 
 }  // namespace dart