Issue 12208012: Disable Fullscreen API on Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12208012: Disable Fullscreen API on Android. (Closed)

Created:
7 years, 10 months ago by John Knottenbelt

Modified:
7 years, 10 months ago

Reviewers:
Peter Beverloo, kerz_chromium, kerz_google

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/webkit-readonly/branches/chromium/1364/

Visibility:
Public.

More Reviews

Description

Disable Fullscreen API on Android. Disable the fullscreen API, as it is not working correctly on Android. BUG=173664

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	LayoutTests/platform/chromium-android/TestExpectations	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	Source/WebKit/chromium/features.gypi	View		3 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

John Knottenbelt

This isn't a cherry-pick because we're still working on the feature upstream. Rather, it is ...

7 years, 10 months ago (2013-02-05 12:01:14 UTC) #1

Peter Beverloo

It feels odd to commit this to a webkit-readonly branch. Isn't the normal workflow to ...

7 years, 10 months ago (2013-02-05 17:31:02 UTC) #3

kerz_google

Ah. We should not commit this to svn.chromium.org, this should go into the upstream webkit ...

7 years, 10 months ago (2013-02-05 17:34:09 UTC) #4

John Knottenbelt

Right, I'll prepare another CL. Thanks for reviewing, guys.

7 years, 10 months ago (2013-02-05 17:35:05 UTC) #5

John Knottenbelt

7 years, 10 months ago (2013-02-06 11:41:54 UTC) #6

On 2013/02/05 17:35:05, John Knottenbelt wrote:
> Right, I'll prepare another CL. Thanks for reviewing, guys.

https://codereview.chromium.org/12208016 was the other CL. Closing this issue.

Expand Messages | Collapse Messages