chrome/browser/test_presubmit.py - Issue 1220793010: [ui/base;css] adding string template expression replacement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/test_presubmit.py

Issue 1220793010: [ui/base;css] adding string template expression replacement (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: removed string16 versions of template expansions Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/ntp4/new_tab_theme.css ('K') | « chrome/browser/resources/ntp4/new_tab_theme.css ('k') | chrome/browser/ui/webui/ntp/ntp_resource_cache.cc » ('j') | chrome/browser/ui/webui/ntp/ntp_resource_cache.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/test_presubmit.py

diff --git a/chrome/browser/test_presubmit.py b/chrome/browser/test_presubmit.py

index 1ad8ed270150efdac5a88b9df39163512ab964c5..68ec8efbbafa7004f21a13f6511aa51de317607f 100755

--- a/chrome/browser/test_presubmit.py

+++ b/chrome/browser/test_presubmit.py

@@ -49,6 +49,15 @@ class HtmlStyleTest(SuperMoxTestBase):

error = checker(1, line)

self.assertEqual('', error, 'Should not be flagged as style error: ' + line)

+ def testTemplateExpressionRemoval(self):

+ lines = [

+ '${tag}',

+ '$${}',

+ '<hr class="${tag}">',

+ ]

+ for line in lines:

+ self.ShouldPassCheck(line, self.checker.ClassesUseDashFormCheck)

Dan Beam 2015/07/14 21:23:40 why are you running this specific check?

Dan Beam 2015/07/15 18:56:41 ping

dschuyler 2015/07/16 02:08:42 The code is removed now.

def testClassesUseDashFormCheckFails(self):

lines = [

' <a class="Foo-bar" href="classBar"> ',