[ui/base;css] adding string template expression replacement

chrome/browser/test_presubmit.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Unit tests for Web Development Style Guide checker."""
 
 import os
 import re
 import sys
@@ skipping 31 matching lines @@
     """Checks that the |checker| flags |line| as a style error."""
     error = checker(1, line)
     self.assertNotEqual('', error, 'Should be flagged as style error: ' + line)
     highlight = GetHighlight(line, error).strip()
 
   def ShouldPassCheck(self, line, checker):
     """Checks that the |checker| doesn't flag |line| as a style error."""
     error = checker(1, line)
     self.assertEqual('', error, 'Should not be flagged as style error: ' + line)
 
+  def testTemplateExpressionRemoval(self):
+    lines = [
+      '${tag}',
+      '$${}',
+      '<hr class="${tag}">',
+    ]
+    for line in lines:
+      self.ShouldPassCheck(line, self.checker.ClassesUseDashFormCheck)

[Dan Beam, 2015/07/14 21:23:40]

why are you running this specific check?

[Dan Beam, 2015/07/15 18:56:41]

ping

[dschuyler, 2015/07/16 02:08:42]

The code is removed now.

+
   def testClassesUseDashFormCheckFails(self):
     lines = [
       ' <a class="Foo-bar" href="classBar"> ',
       '<b class="foo-Bar"> ',
       '<i class="foo_bar" >',
       ' <hr class="fooBar"> ',
     ]
     for line in lines:
       self.ShouldFailCheck(line, self.checker.ClassesUseDashFormCheck)
 
@@ skipping 920 matching lines @@
     opacity: .0;
     opacity: 0.0;
     opacity: 0.;
     border-width: 0mm;
     height: 0cm;
     width: 0in;
 """)
 
 if __name__ == '__main__':
   unittest.main()