Issue 122073003: Track v8 API changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 122073003: Track v8 API changes. (Closed)

Created:
6 years, 11 months ago by Sven Panne

Modified:
6 years, 11 months ago

Reviewers:
dcarney, jochen (gone - plz use gerrit)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Track v8 API changes. R=jochen@chromium.org, dcarney@chromium.org BUG=324225 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242916

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -8 lines)			Patch
M	chrome/test/base/v8_unit_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/public/test/render_view_test.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	content/renderer/v8_value_converter_impl_unittest.cc	View	4 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/svenpanne@chromium.org/122073003/1

6 years, 11 months ago (2014-01-03 20:04:11 UTC) #3

jochen (gone - plz use gerrit)

Committed patchset #1 manually as r242916 (presubmit successful).

6 years, 11 months ago (2014-01-03 20:12:08 UTC) #4

esprehn

6 years, 11 months ago (2014-01-03 22:01:49 UTC) #5

Message was sent while issue was closed.

On 2014/01/03 20:12:08, jochen wrote:
> Committed patchset #1 manually as r242916 (presubmit successful).

I think you broke the build:
http://build.chromium.org/p/chromium/builders/Mac/builds/24229

Expand Messages | Collapse Messages